actions: alert on update link failure & fix deploy action (#355)

Signed-off-by: flakey5 <[email protected]>
Co-authored-by: Matt Cowley <[email protected]>

Author: flakey5

.github/workflows/deploy.yml

@@ -45,16 +45,11 @@ jobs:
 
       - name: Alert on Failure
         if: failure() && github.repository == 'nodejs/release-cloudflare-worker'
-        runs-on: ubuntu-latest
-        steps:
-          - name: Slack Notification
-            uses: rtCamp/action-slack-notify@c33737706dea87cd7784c687dadc9adf1be59990 # 2.3.2
-            env:
-              SLACK_COLOR: '#DE512A'
-              SLACK_ICON: https://github.com/nodejs.png?size=48
-              SLACK_TITLE: Deployment failed (${{ github.ref }})
-              SLACK_MESSAGE: |
-                A deployment of the Release Worker has failed.
-              SLACK_USERNAME: nodejs-bot
-              SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
-        
+        uses: rtCamp/action-slack-notify@c33737706dea87cd7784c687dadc9adf1be59990 # 2.3.2
+        env:
+          SLACK_COLOR: '#DE512A'
+          SLACK_ICON: https://github.com/nodejs.png?size=48
+          SLACK_TITLE: Deployment failed (${{ github.ref }})
+          SLACK_MESSAGE: A deployment of the Release Worker has failed.
+          SLACK_USERNAME: nodejs-bot
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}

.github/workflows/update-links.yml

@@ -63,10 +63,14 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GH_BOT_TOKEN }}
 
-      - name: Deploy to Production
-        if: steps.git_auto_commit.outputs.changes_detected == 'true'
-        run: |
-          gh workflow run deploy.yml
+      - name: Alert on Failure
+        if: failure() && github.repository == 'nodejs/release-cloudflare-worker'
+        uses: rtCamp/action-slack-notify@c33737706dea87cd7784c687dadc9adf1be59990 # 2.3.2
         env:
-          GITHUB_TOKEN: ${{ secrets.GH_BOT_TOKEN }}
+          SLACK_COLOR: '#DE512A'
+          SLACK_ICON: https://github.com/nodejs.png?size=48
+          SLACK_TITLE: Update links failed (${{ github.ref }})
+          SLACK_MESSAGE: The `update-links.yml` action has failed.
+          SLACK_USERNAME: nodejs-bot
+          SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}