review

Signed-off-by: flakey5 <[email protected]>

Author: flakey5

src/providers/r2Provider.ts

@@ -15,6 +15,19 @@ import type {
 } from './provider';
 import { S3Provider } from './s3Provider';
 
+type CachedFile = {
+  name: string;
+  lastModified: string | Date;
+  size: number;
+};
+
+type CachedDirectory = {
+  subdirectories: string[];
+  hasIndexHtmlFile: boolean;
+  files: CachedFile[] | File[];
+  lastModified: string | Date;
+};
+
 type R2ProviderCtorOptions = {
   ctx: Context;
 };
@@ -87,20 +100,19 @@ export class R2Provider implements Provider {
     options?: ReadDirectoryOptions
   ): Promise<ReadDirectoryResult | undefined> {
     if (path in CACHED_DIRECTORIES) {
-      // @ts-expect-error dates may not be parsed at this point, we take care
-      //  of it below
-      const result: ReadDirectoryResult = CACHED_DIRECTORIES[path];
-
-      for (const file of result.files) {
-        if (typeof file.lastModified === 'string') {
-          file.lastModified = new Date(file.lastModified);
-        }
-      }
+      const result: CachedDirectory =
+        CACHED_DIRECTORIES[path as keyof typeof CACHED_DIRECTORIES];
 
       if (typeof result.lastModified === 'string') {
         result.lastModified = new Date(result.lastModified);
+
+        for (const file of result.files) {
+          // @ts-expect-error this isn't readonly
+          file.lastModified = new Date(file.lastModified);
+        }
       }
 
+      // @ts-expect-error at this point the result is parsed already
       return Promise.resolve({
         subdirectories: result.subdirectories,
         files: result.files,