Skip to content

Commit 91f35e7

Browse files
committed
docs: update responses and references
1 parent 3f496a8 commit 91f35e7

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

tools/ossf_best_practices/gold_criteria.md

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Context:
3333

3434
> The project MUST have a "bus factor" of 2 or more. (URL required)
3535
36-
**Met**
36+
**Met. https://github.com/nodejs/node/blob/main/GOVERNANCE.md**
3737

3838
Context:
3939
- [CII Best Practices: Basics](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-basics-1)
@@ -42,7 +42,7 @@ Context:
4242

4343
> The project MUST have at least two unassociated significant contributors.
4444
45-
**Met**
45+
**Met. https://github.com/nodejs/node/blob/main/GOVERNANCE.md**
4646

4747
Context:
4848
- [CII Best Practices: Basics](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-basics-1)
@@ -53,12 +53,13 @@ Context:
5353

5454
> The project MUST include a copyright statement in each source file, identifying the copyright holder (e.g., the [project name] contributors).
5555
56-
**Meet**
56+
**Unmet**
5757

5858
Context:
5959
- [CII Best Practices: Basics](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-basics-1)
6060
- [CII Best Practices: Copyright Per File](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#copyright_per_file)
6161
- [Team Discussion](https://github.com/nodejs/security-wg/pull/956#discussion_r1307391551)
62+
- [Issue to follow up](https://github.com/nodejs/security-wg/issues/1187)
6263

6364
> The project MUST include a license statement in each source file. This MAY be done by including the following inside a comment near the beginning of each file: SPDX-License-Identifier: [SPDX license expression for project](https://spdx.dev/ids/#how)
6465
@@ -67,6 +68,7 @@ Context:
6768
Context:
6869
- [CII Best Practices: Basics](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-basics-1)
6970
- [Team Discussion](https://github.com/nodejs/security-wg/pull/956#discussion_r1307392811)
71+
- [Issue to follow up](https://github.com/nodejs/security-wg/issues/1187)
7072

7173
# Change Control
7274

@@ -90,7 +92,7 @@ Context:
9092

9193
> The project MUST require two-factor authentication (2FA) for developers for changing a central repository or accessing sensitive data (such as private vulnerability reports). This 2FA mechanism MAY use mechanisms without cryptographic mechanisms such as SMS, though that is not recommended.
9294
93-
**Met**
95+
**Met. Node.js org has enabled 2FA for all the members, see: https://github.com/openjs-foundation/security-collab-space/issues/94#issuecomment-1874627417**
9496

9597
Context:
9698
- [CII Best Practices: Change Control](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-change-control-1)
@@ -119,7 +121,7 @@ Context:
119121

120122
> The project MUST have at least 50% of all proposed modifications reviewed before release by a person other than the author, to determine if it is a worthwhile modification and free of known issues which would argue against its inclusion
121123
122-
**Met. Currently the repo is monitored against the OSSF Scorecard, where this is checked every 2 weeks in the Security Team regular meetings. See: https://github.com/nodejs/security-wg/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/tools/ossf_scorecard/report.md**
124+
**Met. The process is documented: https://github.com/nodejs/node/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/doc/contributing/pull-requests.md#reviewing-pull-requests and we use additional tools like the OSSF Scorecard to monitor it**
123125

124126
Context:
125127
- [CII Best Practices: Quality](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-quality-1)
@@ -157,21 +159,24 @@ Context:
157159

158160
> The project MUST have FLOSS automated test suite(s) that provide at least 90% statement coverage if there is at least one FLOSS tool that can measure this criterion in the selected language.
159161
160-
**Met. This is part of the CI Checks in place**
162+
**Met. Report available in https://app.codecov.io/gh/nodejs/node**
161163

162164
Context:
163165
- [CII Best Practices: Quality](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-quality-1)
164166
- [CII Best Practices: Test Statement Coverage 90%](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#test_statement_coverage90)
165167
- [Team Discussion](https://github.com/nodejs/security-wg/pull/956#discussion_r1307405014)
168+
- [Issue to follow up](https://github.com/nodejs/security-wg/issues/1187)
169+
166170

167171
> The project MUST have FLOSS automated test suite(s) that provide at least 80% branch coverage if there is at least one FLOSS tool that can measure this criterion in the selected language.
168172
169-
**Met. This is part of the CI Checks in place**
173+
**Met. Report available in https://app.codecov.io/gh/nodejs/node**
170174

171175
Context:
172176
- [CII Best Practices: Quality](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-quality-1)
173177
- [CII Best Practices: Test Branch Coverage 80%](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#test_branch_coverage80)
174178
- [Team Discussion](https://github.com/nodejs/security-wg/pull/956#discussion_r1307405888)
179+
- [Issue to follow up](https://github.com/nodejs/security-wg/issues/1188)
175180

176181

177182
# Security
@@ -188,6 +193,8 @@ Context:
188193
- [CII Best Practices: Security](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-security-1)
189194
- [Team Discussion](https://github.com/nodejs/security-wg/pull/956#discussion_r1307415866)
190195
- [See related question in Silver Criteria](/tools/ossf_best_practices/silver_criteria.md)
196+
- [Issue to follow up](https://github.com/nodejs/security-wg/issues/1189)
197+
191198

192199
> The software produced by the project MUST, if it supports or uses TLS, support at least TLS version 1.2. Note that the predecessor of TLS was called SSL. If the software does not use TLS, select "not applicable" (N/A).
193200
@@ -208,6 +215,7 @@ Context:
208215
Context:
209216
- [CII Best Practices: Security](https://github.com/coreinfrastructure/best-practices-badge/blob/a51ed45fdcd8e2959781a86929f561521ac2e0e0/docs/other.md#upgrade-security-1)
210217
- [Team Discussion](https://github.com/nodejs/security-wg/pull/956#discussion_r1307413951)
218+
- [Issue to follow up](https://github.com/nodejs/security-wg/issues/1190)
211219

212220
## Other security issues
213221

0 commit comments

Comments
 (0)