-
-
Notifications
You must be signed in to change notification settings - Fork 31
feat(tape-to-node-test): first draft
#296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Bruno Rodrigues <[email protected]>
ljharb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(btw the diff would read cleaner if it was "output" instead of "expected", because then "input" would be sorted before "output" instead of the reverse)
some of my comments apply on all the input/expected combos, so i'll post this now before being exhaustive
the input/expect structure isn't chose by us it's the design of the codemod tool |
Co-authored-by: Bruno Rodrigues <[email protected]>
|
@ljharb i had resolved all of your concerns |
Related issue
Close #260