-
-
Notifications
You must be signed in to change notification settings - Fork 31
ci: publish codemods as trusted publisher #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
FYI: the proposal from Codemod team Fact:
But now we don't have any problems with that just create a tags. So idk what is the best world @nodejs/userland-migrations what do you think ? |
That won't not needed if you use OIDC publishers. As long as the github actions is run in a repo in the
That again is not needed as long as the codemods are scoped |
Co-authored-by: Jacob Smith <[email protected]>
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define the permissions inside the job.
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Opening this PR as an implementation example of @AugustinMauroy proposal in #307.
If merged, you'll probably want to delete the
CODEMOD_TOKENsecret.No other configuration should be required as
nodejsorg on GitHub is alsonodejsorg on Codemod.Fixes #307 if merged