Skip to content

Feat: add getModuleDependencies utillity #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brunocroh merged 16 commits into from
Jan 17, 2026
Merged

Feat: add getModuleDependencies utillity #326

brunocroh merged 16 commits into from
Jan 17, 2026

Conversation

@brunocroh
Copy link
Member

@brunocroh brunocroh commented Jan 3, 2026 •
edited
Loading

Add a getModuleDependencies utility to replace cases like the one below:

  return [
		...getNodeRequireCalls(node, name),
		...getNodeImportStatements(node, name),
		...getNodeImportCalls(node, name),
	];

Also update the recipes to use it.

brunocroh and others added 14 commits January 3, 2026 14:12
@brunocroh @JakobJingleheimer
add getModuleDependencies utility function
f99c856 
Co-authored-by: Jacob Smith <[email protected]>
@brunocroh
improve error log from resolve-binding-path
21403d3
@brunocroh
refactor(chalk-to-util-styletext): add getModuleDependencies
23c3e99
@brunocroh
refactor(crypto-fips-to-getFips): add getModuleDependencies
186b1a2
@brunocroh
refactor(crypto-rsa-pss-update): add getModuleDependencies
cc420d2
@brunocroh
refactor(dirent-path-to-parent-path): add getModuleDependencies
5cf382c
@brunocroh
refactor(fs-truncate-fd-deprecation): add getModuleDependencies
398fcf4
@brunocroh
refactor(process-assert-to-node-assert): add getModuleDependencies
054cdc1
@brunocroh
refactor(repl-classes-with-new): add getModuleDependencies
220b581
@brunocroh
refactor(slow-buffer-to-buffer-lloc-unsafe-slow): add getModuleDepend…
fe7935a 
…encies
@brunocroh
refactor(util-extend-to-object-assign): add getModuleDependencies
729064c
@brunocroh
refactor(util-is): add getModuleDependencies
74bad05
@brunocroh
refactor(util-print-to-console.log): add getModuleDependencies
14b707a
@brunocroh
refactor(zlib-bytesread-to-byteswritten): add getModuleDependencies
278e108
@brunocroh brunocroh mentioned this pull request Jan 3, 2026
Open
@brunocroh brunocroh changed the title Feat/add get dep nodes Feat: add getModuleDependencies utillity Jan 3, 2026
@AugustinMauroy
Copy link
Member

AugustinMauroy commented Jan 3, 2026

Noice !

could you document it in the utils readme ?

@brunocroh
Copy link
Member Author

brunocroh commented Jan 3, 2026

Noice !

could you document it in the utils readme ?

good catch, done. 🚀

@brunocroh brunocroh requested a review from a team January 9, 2026 09:40
@brunocroh brunocroh added the awaiting reviewer Author has responded and needs action from the reviewer label Jan 9, 2026
JakobJingleheimer
JakobJingleheimer approved these changes Jan 17, 2026
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t! 🙌

@JakobJingleheimer JakobJingleheimer added g2g No outstanding concerns, discussions, or issues. and removed awaiting reviewer Author has responded and needs action from the reviewer labels Jan 17, 2026
@JakobJingleheimer
Copy link
Member

JakobJingleheimer commented Jan 17, 2026

@brunocroh shall we land this? (not sure if there are other migrations that have since landed that should be included here too)

@brunocroh
Copy link
Member Author

brunocroh commented Jan 17, 2026

@brunocroh shall we land this? (not sure if there are other migrations that have since landed that should be included here too)

I checked here, and we didn’t have anything new. Since it’s been merged, should we release new versions of all the impacted recipes?

@JakobJingleheimer
Copy link
Member

JakobJingleheimer commented Jan 17, 2026

Yep, sounds good 🙂

@brunocroh brunocroh merged commit 7b3af25 into nodejs:main Jan 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

g2g No outstanding concerns, discussions, or issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brunocroh @AugustinMauroy @JakobJingleheimer