From d7cac96e7356b590f2b66a516a88b2568bb51f2f Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Sun, 13 Jul 2025 11:08:28 -0700 Subject: [PATCH 1/3] Add web-infra onboarding docs Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> --- onboarding/web-infra.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 onboarding/web-infra.md diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md new file mode 100644 index 0000000..bcfd086 --- /dev/null +++ b/onboarding/web-infra.md @@ -0,0 +1,23 @@ +# Web Infrastructure Onboarding + +This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team. + +Please note these tasks should only be performed after the person's nomination has passed. + +## Tasks + +Tasks prefixed by `Member:` are for the new member to complete. +Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete. + +- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. + - Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping. +- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases. +- [ ] Web Admin: Recommend member sign their Git commits if not already doing so. +- [ ] Web Admin: Add member to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. +- [ ] Member: Add yourself to the [membership list document](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra). +- [ ] Member: Open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. +- [ ] Web Admin: Invite member to Node.js' Sentry account. + - [ ] Member: Enable physical or passkey 2FA on their Sentry account. + +Note there isn't currently a set level of access that Web Infra members has to some resources such as Cloudflare. +You may be granted access if needed, but will not be given it initially since we do not control it. From adaaff6dad9fc442b4ee7819a5b3a338e5aa77fe Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Wed, 16 Jul 2025 16:22:31 -0500 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Aviv Keller Co-authored-by: Matt Cowley --- onboarding/web-infra.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index bcfd086..36f630e 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -1,8 +1,8 @@ -# Web Infrastructure Onboarding +# @nodejs/web-infra Onboarding -This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team. +This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra). -Please note these tasks should only be performed after the person's nomination has passed. +Please note these tasks should only be performed after an individual's nomination has passed. ## Tasks @@ -18,6 +18,10 @@ Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to compl - [ ] Member: Open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. - [ ] Web Admin: Invite member to Node.js' Sentry account. - [ ] Member: Enable physical or passkey 2FA on their Sentry account. +- [ ] Web Admin: Invite member to Node.js' Vercel account. + - [ ] Member: Enable physical or passkey 2FA on their Vercel account. -Note there isn't currently a set level of access that Web Infra members has to some resources such as Cloudflare. +There currently is not a set level of access that @nodejs/web-infra members have on Cloudflare. + +Should you need additional access, it may be granted, however, access is not given by default. You may be granted access if needed, but will not be given it initially since we do not control it. From 2dc9f131fe6d38afcd03fdb435954b3b93deff98 Mon Sep 17 00:00:00 2001 From: flakey5 <73616808+flakey5@users.noreply.github.com> Date: Sun, 27 Jul 2025 09:17:37 -0700 Subject: [PATCH 3/3] review Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com> --- onboarding/web-infra.md | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/onboarding/web-infra.md b/onboarding/web-infra.md index 36f630e..9f26c60 100644 --- a/onboarding/web-infra.md +++ b/onboarding/web-infra.md @@ -3,25 +3,30 @@ This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra). Please note these tasks should only be performed after an individual's nomination has passed. +To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md). ## Tasks -Tasks prefixed by `Member:` are for the new member to complete. -Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete. - -- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it. - - Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping. -- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases. -- [ ] Web Admin: Recommend member sign their Git commits if not already doing so. -- [ ] Web Admin: Add member to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. -- [ ] Member: Add yourself to the [membership list document](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra). -- [ ] Member: Open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. -- [ ] Web Admin: Invite member to Node.js' Sentry account. - - [ ] Member: Enable physical or passkey 2FA on their Sentry account. -- [ ] Web Admin: Invite member to Node.js' Vercel account. - - [ ] Member: Enable physical or passkey 2FA on their Vercel account. +- [ ] The nominee should open a pull request in [nodejs/web-team](https://github.com/nodejs/web-team) adding themselves to the [MEMBERS.md](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra) document. + - [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed. + - [ ] Please link any additional issues or pull requests back to this one for record keeping purposes. +- [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team. +- [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault. +- [ ] A Web Admin should invite the nominee to Node.js' Sentry account. + - [ ] The nominee should enable physical or passkey 2FA on their Sentry account. +- [ ] A Web Admin should invite the nominee to Node.js' Vercel account. + - [ ] The nominee should enable physical or passkey 2FA on their Vercel account. +- [ ] The nominee should open a pull request in [nodejs/email](https://github.com/nodejs/email) to add their email to the `nodejs-crowdin` email chain. +- [ ] An OpenJS Slack Admin should add their Slack account to the `nodejs-website-team` team. + +### Recommendations + +- [ ] A Web Admin should recommend the nominee have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account +- [ ] A Web Admin should recommend any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device. +- [ ] A Web Admin should recommend the nominee sign their Git commits. + +## Notes There currently is not a set level of access that @nodejs/web-infra members have on Cloudflare. -Should you need additional access, it may be granted, however, access is not given by default. -You may be granted access if needed, but will not be given it initially since we do not control it. +Should you need additional access, it may be granted, however, access is not given by default since we do not control it.