-
-
Notifications
You must be signed in to change notification settings - Fork 3
chore(gov): remove web-standards #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CC @nodejs/TSC |
The issue didn't even pass and you're opening a PR already? 🫠 |
The issue received 5 approvals and no objections after 72 hours, which I believe qualifies as a pass. I believe this aligns with the typical process for administrative changes as outlined in the nodejs/admin repo |
I'd consider it passing once it gets closed no? |
No? I would assume that the issue gets closed when the action gets taken to resolve it. i.e. a Node.js Core Collaborator nomination issue is closed by the PR to add the nominee, not when the nomination passes. |
Bump @nodejs/TSC |
This comment was marked as outdated.
This comment was marked as outdated.
We need a tsc-agenda to add this to the TSC agenda. To clarify for @nodejs/tsc we want the web-standards team to be removed from the @nodejs/web group and just be added diredctly to the same level all other "technical teams" for pining @ nodejs/node are. |
This comment was marked as resolved.
This comment was marked as resolved.
SGTM (or that was what I thought how it worked in the first place). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey TSC! A lot of yall have approved this, but we still need you to remove the team as a child, as defined in the PR description, can you please do that? Once it's done, feel free to remove the agenda and blocked label. |
Closes #10.
Before merging this, the following steps are required: