fix: handle missing key more elegantly (#11)

* fix: handle missing key more elegantly

* fix: simplify type

Author: jbristow

nodestream_github/transformer/repo.py

@@ -19,19 +19,33 @@ def __init__(
         full_name_key: str = "full_name",
         **kwargs: any,
     ):
-
         self.client = GithubRestApiClient(**kwargs)
         self.full_name_key = full_name_key
 
     async def transform_record(
         self,
         record: types.GithubRepo,
     ) -> AsyncGenerator[types.GithubUser]:
-        (repo_owner, repo_name) = record[self.full_name_key].split("/")
-        logging.debug("Transforming record %s/%s", repo_owner, repo_name)
+        logging.debug("Attempting to transform %s", record)
 
+        full_name = record.get(self.full_name_key)
         simplified_repo = simplify_repo(record)
 
+        if full_name is not None:
+            async for user in self._transform(full_name, simplified_repo):
+                yield user
+        else:
+            logging.info("No full_name key found in record %s", record)
+
+    async def _transform(
+        self,
+        full_name: str,
+        simplified_repo: types.SimplifiedRepo,
+    ) -> AsyncGenerator[types.GithubUser]:
+        (repo_owner, repo_name) = full_name.split("/")
+
+        logging.debug("Transforming repo %s/%s", repo_owner, repo_name)
+
         async for collaborator in self.client.fetch_collaborators_for_repo(
             owner_login=repo_owner,
             repo_name=repo_name,

tests/transformer/test_repo.py

@@ -75,3 +75,20 @@ async def test_transform_records_alt_key(gh_rest_mock: GithubHttpxMock):
         OCTOCAT_USER | {"repository": repo_summary, "affiliation": "direct"},
         TURBO_USER | {"repository": repo_summary, "affiliation": "outside"},
     ]
+
+
+@pytest.mark.asyncio
+async def test_no_full_name_key():
+    transformer = RepoToCollaboratorsTransformer(
+        full_name_key="full_name",
+        auth_token="test-token",
+        github_hostname=DEFAULT_HOSTNAME,
+        user_agent="test-agent",
+        max_retries=0,
+        per_page=DEFAULT_PER_PAGE,
+    )
+    modified_repo = HELLO_WORLD_REPO.copy()
+    del modified_repo["full_name"]
+
+    response = [r async for r in transformer.transform_record(modified_repo)]
+    assert response == []