fix: clean up kwargs and lowercase any (#17)

Author: jbristow

nodestream_github/client/githubclient.py

@@ -7,6 +7,7 @@
 import logging
 from collections.abc import AsyncGenerator
 from enum import Enum
+from typing import Any
 
 import httpx
 from limits import RateLimitItem, RateLimitItemPerMinute
@@ -82,7 +83,7 @@ def __init__(
         max_retries: int | None = None,
         rate_limit_per_minute: int | None = None,
         max_retry_wait_seconds: int | None = None,
-        **_kwargs: any,
+        **_kwargs: dict[str, Any],
     ):
         if per_page is None:
             per_page = DEFAULT_PAGE_SIZE

nodestream_github/orgs.py

@@ -6,6 +6,7 @@
 """
 
 from collections.abc import AsyncGenerator
+from typing import Any
 
 from nodestream.pipeline import Extractor
 
@@ -25,7 +26,7 @@ def __init__(
         *,
         include_members: bool | None = True,
         include_repositories: bool | None = True,
-        **kwargs: any,
+        **kwargs: dict[str, Any],
     ):
 
         self.include_members = include_members is True

nodestream_github/repos.py

@@ -7,6 +7,7 @@
 
 from collections.abc import AsyncGenerator
 from dataclasses import dataclass
+from typing import Any
 
 from nodestream.pipeline import Extractor
 
@@ -19,7 +20,7 @@
 logger = get_plugin_logger(__name__)
 
 
-def _dict_val_to_bool(d: dict[str, any], key: str) -> bool:
+def _dict_val_to_bool(d: dict[str, Any], key: str) -> bool:
     value = d.get(key)
     if value is None:
         return False
@@ -46,7 +47,7 @@ def user_any(self) -> bool:
         return self.user_public or self.user_private
 
     @staticmethod
-    def from_dict(raw_dict: dict[str, any]) -> "CollectWhichRepos":
+    def from_dict(raw_dict: dict[str, Any]) -> "CollectWhichRepos":
         org_all = _dict_val_to_bool(raw_dict, "org_all")
         user_all = _dict_val_to_bool(raw_dict, "user_all")
 
@@ -62,8 +63,8 @@ def from_dict(raw_dict: dict[str, any]) -> "CollectWhichRepos":
 class GithubReposExtractor(Extractor):
     def __init__(
         self,
-        collecting: CollectWhichRepos | dict[str, any] | None = None,
-        **kwargs: any,
+        collecting: CollectWhichRepos | dict[str, Any] | None = None,
+        **kwargs: dict[str, Any],
     ):
         if isinstance(collecting, CollectWhichRepos):
             self.collecting = collecting

nodestream_github/teams.py

@@ -6,6 +6,7 @@
 """
 
 from collections.abc import AsyncGenerator
+from typing import Any
 
 from nodestream.pipeline import Extractor
 
@@ -20,7 +21,7 @@
 
 
 class GithubTeamsExtractor(Extractor):
-    def __init__(self, **github_client_kwargs: any):
+    def __init__(self, **github_client_kwargs: dict[str, Any]):
         self.client = GithubRestApiClient(**github_client_kwargs)
 
     async def extract_records(self) -> AsyncGenerator[TeamRecord]:

nodestream_github/transformer/repo.py

@@ -1,5 +1,6 @@
 import logging
 from collections.abc import AsyncGenerator
+from typing import Any
 
 from nodestream.pipeline import Transformer
 
@@ -17,7 +18,7 @@ def __init__(
         self,
         *,
         full_name_key: str = "full_name",
-        **kwargs: any,
+        **kwargs: dict[str, Any],
     ):
         self.client = GithubRestApiClient(**kwargs)
         self.full_name_key = full_name_key

nodestream_github/types/enums.py

@@ -23,13 +23,13 @@ class UserRepoType(StrEnum):
     MEMBER = "member"
 
 
-class OrgMemberRole:
+class OrgMemberRole(StrEnum):
     ALL = "all"
     ADMIN = "admin"
     MEMBER = "member"
 
 
-class TeamMemberRole:
+class TeamMemberRole(StrEnum):
     ALL = "all"
     MAINTAINER = "maintainer"
     MEMBER = "member"

nodestream_github/users.py

@@ -6,6 +6,7 @@
 """
 
 from collections.abc import AsyncGenerator
+from typing import Any
 
 from nodestream.pipeline import Extractor
 
@@ -19,7 +20,7 @@
 
 
 class GithubUserExtractor(Extractor):
-    def __init__(self, **github_client_kwargs: any):
+    def __init__(self, **github_client_kwargs: dict[str, Any]):
         self.client = GithubRestApiClient(**github_client_kwargs)
 
     async def extract_records(self) -> AsyncGenerator[UserRecord]:

tests/data/orgs.py

@@ -1,9 +1,11 @@
+from typing import Any
+
 from nodestream_github.types import GithubOrg, GithubOrgSummary
 from tests.data.util import encode_as_node_id
 
 
 def org_summary(
-    *, org_login: str = "github", org_id: int = 1, **kwargs: any
+    *, org_login: str = "github", org_id: int = 1, **kwargs: dict[str, Any]
 ) -> GithubOrgSummary:
     return {
         "login": org_login,

tests/data/repos.py

@@ -1,14 +1,16 @@
+from typing import Any
+
 from nodestream_github.types import GithubRepo
 from tests.data.users import OCTOCAT_USER
 from tests.data.util import encode_as_node_id
 
 
 def repo(
     *,
-    owner: dict[str, any] | None = None,
+    owner: dict[str, Any] | None = None,
     repo_name: str = "Hello-World",
     repo_id: int = 1296269,
-    **kwargs: any,
+    **kwargs: dict[str, Any],
 ) -> GithubRepo:
 
     repo_owner = OCTOCAT_USER if owner is None else owner

tests/data/teams.py

@@ -1,3 +1,5 @@
+from typing import Any
+
 from nodestream_github.types import GithubOrgSummary, GithubTeam, GithubTeamSummary
 from tests.data.orgs import GITHUB_ORG
 from tests.data.util import encode_as_node_id
@@ -8,7 +10,7 @@ def team_summary(
     team_id: int = 1,
     slug: str = "justice-league",
     org_login: str = "github",
-    **kwargs: any,
+    **kwargs: dict[str, Any],
 ) -> GithubTeamSummary:
     return {
         "id": team_id,
@@ -32,7 +34,7 @@ def team(
     team_id: int = 1,
     organization: GithubOrgSummary | None = None,
     slug: str = "justice-league",
-    **kwargs: any,
+    **kwargs: dict[str, Any],
 ) -> GithubTeam:
     org = organization if organization else GITHUB_ORG
     summary = team_summary(team_id=team_id, org_login=org["login"], slug=slug)