Skip to content

Commit 9736ee9

Browse files
committed
fmt
1 parent 8474a7a commit 9736ee9

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

nodestream_github/client/githubclient.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ def validate_positive_int(value: int) -> int:
9292
exception_msg = "Formatting lookback period failed"
9393
raise ValueError(exception_msg) from e
9494

95+
9596
def generate_date_range(lookback_period: dict[str, int]) -> list[str]:
9697
"""
9798
Generate a list of date strings in YYYY-MM-DD format for
@@ -105,10 +106,10 @@ def generate_date_range(lookback_period: dict[str, int]) -> list[str]:
105106

106107
delta_days = (end_date - start_date).days + 1
107108
return [
108-
(start_date + timedelta(days=i)).strftime("%Y-%m-%d")
109-
for i in range(delta_days)
109+
(start_date + timedelta(days=i)).strftime("%Y-%m-%d") for i in range(delta_days)
110110
]
111111

112+
112113
def build_search_phrase(
113114
actions: list[str],
114115
actors: list[str],
@@ -423,6 +424,7 @@ async def fetch_enterprise_audit_log(
423424
dates = generate_date_range(lookback_period) or [None]
424425

425426
for target_date in dates:
427+
print(target_date)
426428
search_phrase = build_search_phrase(
427429
actions=actions,
428430
actors=actors,

tests/client/test_githubclient.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,25 +135,30 @@ def test_all_null_args():
135135
# noinspection PyTypeChecker
136136
assert GithubRestApiClient(auth_token=None, github_hostname=None)
137137

138+
138139
# Test generate_date_range
139140

141+
140142
def test_generate_date_range_empty_lookback_period():
141143
result = generate_date_range({})
142144
assert result == []
143145

146+
144147
@freeze_time("2025-08-01")
145148
def test_generate_date_range_days_only():
146149
result = generate_date_range({"days": 3})
147150
expected = ["2025-07-29", "2025-07-30", "2025-07-31", "2025-08-01"]
148151
assert result == expected
149152

153+
150154
@freeze_time("2025-08-01")
151155
def test_generate_date_range_zero_days():
152156
"""Test with zero days (same day only)."""
153157
result = generate_date_range({"days": 0})
154158
expected = ["2025-08-01"]
155159
assert result == expected
156160

161+
157162
@freeze_time("2025-08-01")
158163
def test_generate_date_range_months_only():
159164
result = generate_date_range({"months": 1})
@@ -162,20 +167,23 @@ def test_generate_date_range_months_only():
162167
assert result[0] == "2025-07-01"
163168
assert result[-1] == "2025-08-01"
164169

170+
165171
@freeze_time("2025-08-01")
166172
def test_generate_date_range_years_only():
167173
result = generate_date_range({"years": 1})
168174
assert len(result) == 366
169175
assert result[0] == "2024-08-01"
170176
assert result[-1] == "2025-08-01"
171177

178+
172179
@freeze_time("2025-08-01")
173180
def test_generate_date_range_combined_periods():
174181
"""Test with combined periods."""
175182
result = generate_date_range({"months": 1, "days": 5})
176183
assert result[0] == "2025-06-26"
177184
assert result[-1] == "2025-08-01"
178185

186+
179187
@freeze_time("2025-08-01")
180188
def test_generate_date_range_complex_combination():
181189
"""Test with years, months, and days."""
@@ -186,6 +194,7 @@ def test_generate_date_range_complex_combination():
186194

187195
# Test validate_lookback_period
188196

197+
189198
def test_validate_lookback_period_valid_input():
190199
result = validate_lookback_period({"days": 7, "months": 2, "years": 1})
191200
expected = {"days": 7, "months": 2, "years": 1}
@@ -207,6 +216,7 @@ def test_validate_lookback_period_string_to_int_conversion():
207216
expected = {"days": 7, "months": 2}
208217
assert result == expected
209218

219+
210220
def test_validate_lookback_period_zero_value():
211221
with pytest.raises(ValueError, match="Formatting lookback period failed"):
212222
validate_lookback_period({"days": 0})
@@ -244,4 +254,4 @@ def test_validate_lookback_period_invalid_type():
244254

245255
def test_validate_lookback_period_none_value():
246256
with pytest.raises(ValueError, match="Formatting lookback period failed"):
247-
validate_lookback_period({"days": None})
257+
validate_lookback_period({"days": None})

tests/test_audit.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ async def test_get_audit_lookback_periods(
164164
expected_path: str,
165165
):
166166
from nodestream_github.client.githubclient import generate_date_range
167-
167+
168168
extractor = GithubAuditLogExtractor(
169169
auth_token="test-token",
170170
github_hostname=DEFAULT_HOSTNAME,
@@ -177,14 +177,14 @@ async def test_get_audit_lookback_periods(
177177
)
178178

179179
expected_dates = generate_date_range(lookback_period)
180-
180+
181181
# Mock the first date call with the expected_path
182182
gh_rest_mock.get_enterprise_audit_logs(
183183
status_code=200,
184184
search_phrase=expected_path,
185185
json=GITHUB_AUDIT,
186186
)
187-
187+
188188
# Mock additional dates if there are more than one
189189
test_dates = expected_dates[:3] if len(expected_dates) > 3 else expected_dates
190190
if len(test_dates) > 1:
@@ -198,9 +198,10 @@ async def test_get_audit_lookback_periods(
198198

199199
# replacing generate_date_range with test dates so that we don't iterate through all dates
200200
import nodestream_github.client.githubclient as client_module
201+
201202
original_generate = client_module.generate_date_range
202203
client_module.generate_date_range = lambda x: test_dates
203-
204+
204205
try:
205206
all_records = [record async for record in extractor.extract_records()]
206207
expected_output = GITHUB_EXPECTED_OUTPUT * len(test_dates)

0 commit comments

Comments
 (0)