Skip to content

Commit e0acccd

Browse files
authored
Merge pull request #1 from nodestream-proj/update-ci
chore: update ci action
2 parents 5f92a97 + 15192d4 commit e0acccd

File tree

2 files changed

+23
-9
lines changed

2 files changed

+23
-9
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
# Summary of Change
2-
Jira issue: https://jira.intuit.com/browse/SKIP-XXXX
32

43
<Your Summary Goes Here>
54

65
## Before Review
7-
- [ ] Jira Story In Description/Body
86
- [ ] Unit Tests are Added/Updated and meet at-least 85% coverage criteria for that feature
97

108
## Before Merge

.github/workflows/ci.yml

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
name: CI Workflow
2+
permissions:
3+
pull-requests: write
24

35
on:
46
push:
@@ -10,21 +12,35 @@ jobs:
1012
runs-on: ubuntu-latest
1113

1214
steps:
13-
- uses: actions/checkout@v3
15+
- uses: actions/checkout@v4
1416
- name: Install poetry
1517
run: pipx install poetry
1618
- name: Set up Python
17-
uses: actions/setup-python@v4
19+
uses: actions/setup-python@v5
1820
with:
19-
python-version: "3.11"
21+
python-version: "3.12"
2022
cache: 'poetry'
2123
- name: Install Dependencies
2224
run: |
2325
pip install --upgrade pip
2426
pip install --upgrade setuptools
25-
poetry env use "3.11"
27+
poetry env use "3.12"
2628
poetry install
27-
- name: Run Lints
29+
- name: Setup reviewdog
30+
uses: reviewdog/action-setup@v1
31+
- name: Run black
32+
env:
33+
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2834
run: |
29-
poetry run black nodestream_akamai --check
30-
poetry run isort nodestream_akamai --check-only
35+
poetry run black nodestream_github tests --check --diff --quiet | reviewdog -f=diff -name="black-check" -level=error -reporter=github-pr-review
36+
- name: Run isort
37+
run: |
38+
poetry run isort nodestream_github tests --check-only
39+
- name: Run Lint
40+
env:
41+
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
42+
run: |
43+
poetry run ruff check nodestream_github tests --output-format rdjson | reviewdog -f=rdjson -name="ruff-check" -level=warning -reporter=github-pr-review
44+
- name: Run Tests
45+
run: |
46+
poetry run pytest

0 commit comments

Comments
 (0)