Skip to content

Commit 3511c09

Browse files
committed
Fixing logging issues
1 parent c3229d6 commit 3511c09

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

nodestream_plugin_neo4j/neo4j_database.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def __init__(
8282
self.max_retry_attempts = max_retry_attempts
8383
self.retry_factor = retry_factor
8484
self._driver = None
85-
self.counts_by_query: set[Query] = set()
85+
self.query_set: set[Query] = set()
8686

8787
def acquire_driver(self) -> AsyncDriver:
8888
self._driver = self.driver_factory()
@@ -94,12 +94,15 @@ def driver(self):
9494
return self._driver
9595

9696
def log_query_start(self, query: Query):
97-
if query.query_statement not in self.counts_by_query:
97+
if query.query_statement not in self.query_set:
9898
self.logger.info(
99-
f"Executing Cypher Query to Neo4j: {query.query_statement}",
100-
extra={"uri": self.driver._pool.address.host},
99+
"Executing Cypher Query to Neo4j.",
100+
extra={
101+
"query": query.query_statement,
102+
"uri": self.driver._pool.address.host,
103+
},
101104
)
102-
self.counts_by_query.add(query.query_statement)
105+
self.query_set.add(query.query_statement)
103106

104107
async def _execute_query(
105108
self,
@@ -123,7 +126,7 @@ async def _execute_query(
123126

124127
def log_error_messages_from_statistics(self, statistics: Neo4jQueryStatistics):
125128
for error in statistics.error_messages:
126-
self.logger.error("Query Error Occurred: %s", error)
129+
self.logger.error("Query Error Occurred.", extra={"error": error})
127130

128131
async def execute(
129132
self,
@@ -139,7 +142,8 @@ async def execute(
139142
return await self._execute_query(query, log_result, routing_)
140143
except RETRYABLE_EXCEPTIONS as e:
141144
self.logger.warning(
142-
f"Error executing query, retrying. Attempt {attempts + 1}",
145+
"Error executing query, retrying. Attempt %s",
146+
attempts,
143147
exc_info=e,
144148
)
145149
await asyncio.sleep(self.retry_factor * attempts)

0 commit comments

Comments
 (0)