Skip to content

Commit fba7b00

Browse files
committed
1 parent c802cbc commit fba7b00

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

nodestream_plugin_neo4j/ingest_query_builder.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import re
2-
from datetime import datetime, timedelta
32
from functools import cache, wraps
43
from typing import Iterable
54

@@ -18,6 +17,8 @@
1817
TimeToLiveConfiguration,
1918
)
2019
from nodestream.schema import GraphObjectType
20+
from pandas import Timedelta, Timestamp
21+
2122

2223
from .query import Query, QueryBatch
2324

@@ -231,7 +232,7 @@ def generate_batch_update_relationship_query_batch(
231232
return QueryBatch(query, params)
232233

233234
def generate_ttl_match_query(self, config: TimeToLiveConfiguration) -> Query:
234-
earliest_allowed_time = datetime.utcnow() - timedelta(
235+
earliest_allowed_time = Timestamp.utcnow() - Timedelta(
235236
hours=config.expiry_in_hours
236237
)
237238
params = {"earliest_allowed_time": earliest_allowed_time}

tests/unit/test_ingest_query_builder.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
from datetime import datetime
1+
from unittest.mock import patch
22

33
import pytest
4-
from freezegun import freeze_time
54
from hamcrest import assert_that, equal_to, equal_to_ignoring_whitespace
65
from nodestream.databases.query_executor import (
76
OperationOnNodeIdentity,
@@ -23,14 +22,15 @@
2322
Neo4jIngestQueryBuilder,
2423
)
2524
from nodestream_plugin_neo4j.query import COMMIT_QUERY, Query, QueryBatch
25+
from pandas import Timestamp
2626

2727

2828
@pytest.fixture
2929
def query_builder():
3030
return Neo4jIngestQueryBuilder(True)
3131

3232

33-
GREATEST_DAY = datetime(1998, 3, 25, 2, 0, 1)
33+
GREATEST_DAY = Timestamp(1998, 3, 25, 2, 0, 1)
3434

3535
BASIC_NODE_TTL = TimeToLiveConfiguration(
3636
graph_object_type=GraphObjectType.NODE,
@@ -90,7 +90,7 @@ def query_builder():
9090
},
9191
)
9292

93-
93+
@patch("pandas.Timestamp.utcnow")
9494
@pytest.mark.parametrize(
9595
"ttl,expected_query",
9696
[
@@ -100,8 +100,8 @@ def query_builder():
100100
(REL_TTL_WITH_CUSTOM_QUERY, REL_TTL_WITH_CUSTOM_QUERY_EXPECTED_QUERY),
101101
],
102102
)
103-
@freeze_time("1998-03-25 12:00:01")
104-
def test_generates_expected_queries(query_builder, ttl, expected_query):
103+
def test_generates_expected_queries(mocked_utcnow, query_builder, ttl, expected_query):
104+
mocked_utcnow.return_value = Timestamp(1998, 3, 25, 12, 0, 1)
105105
resultant_query = query_builder.generate_ttl_query_from_configuration(ttl)
106106
assert_that(resultant_query, equal_to(expected_query))
107107

0 commit comments

Comments
 (0)