Merge pull request #410 from AGhafaryy/lazyloaded-args

adding logging and removing only_one arg

Author: zprobst

nodestream/pipeline/object_storage.py

@@ -1,6 +1,7 @@
 import base64
 import hashlib
 import hmac
+import logging
 import pickle
 from abc import ABC, abstractmethod
 from dataclasses import dataclass
@@ -13,6 +14,9 @@
 from ..subclass_registry import SubclassRegistry
 from .extractors.credential_utils import AwsClientFactory
 
+logger = logging.getLogger(__name__)
+
+
 OBJECT_STORE_REGISTRY = SubclassRegistry(ignore_overrides=True)
 T = TypeVar("T")
 
@@ -248,6 +252,9 @@ def delete(self, key: str):
 class NullObjectStore(ObjectStore, alias="null"):
     """An object store that does not store any objects."""
 
+    def __init__(self):
+        logger.error("Using null ObjectStore. No persistence is configured.")
+
     def get(self, _: str) -> Optional[bytes]:
         return None
 

nodestream/project/storage.py

@@ -26,7 +26,7 @@ def to_file_data(self):
             name=self.name,
             type=self.storage_type,
             hmac_key=self.hmac_key,
-            **self.arguments
+            **self.arguments,
         )
 
     @staticmethod
@@ -46,7 +46,7 @@ def describe_yaml_schema():
             {
                 "name": str,
                 "type": str,
-                Optional("hmac_key"): Or(LazyLoadedArgument, str, only_one=True),
+                Optional("hmac_key"): Or(LazyLoadedArgument, str),
                 Optional(str): object,
             }
         )