Skip to content

Commit 2d81ec8

Browse files
committed
Fixing Spelling, and making missing objectstore message an INFO log.
1 parent ffae2d8 commit 2d81ec8

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

nodestream/cli/operations/initialize_logger.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from pythonjsonlogger.jsonlogger import JsonFormatter
66

7-
from nodestream.cli.commands.nodestream_command import BaseCommand
7+
from nodestream.cli.commands.nodestream_command import NodestreamCommand
88
from nodestream.metrics import Metrics
99
from nodestream.logging_metrics import MetricsLoggingHandler
1010
from .operation import Operation
@@ -40,6 +40,6 @@ def record_factory(*args, **kwargs):
4040

4141

4242
class InitializeLogger(Operation):
43-
async def perform(self, command: BaseCommand) -> Any:
43+
async def perform(self, command: NodestreamCommand) -> Any:
4444
if command.has_json_logging_set:
4545
configure_logging_with_json_defaults()

nodestream/pipeline/object_storage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ class NullObjectStore(ObjectStore, alias="null"):
253253
"""An object store that does not store any objects."""
254254

255255
def __init__(self):
256-
logger.error("Using null ObjectStore. No persistence is configured.")
256+
logger.info("Using null ObjectStore. No persistence is configured.")
257257

258258
def get(self, _: str) -> Optional[bytes]:
259259
return None

nodestream/project/run_request.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ async def execute_with_definition(self, definition: PipelineDefinition):
5656
await pipeline.run(self.progress_reporter)
5757

5858
def set_configuration(self, scope_config: ScopeConfig):
59-
self.initialization_arguments.effecitve_config_values = scope_config
59+
self.initialization_arguments.effective_config_values = scope_config

tests/unit/pipeline/test_pipeline_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def test_pipeline_file_loads_lazy():
7070

7171
def test_pipeline_file_loads_config_when_set():
7272
init_args = PipelineInitializationArguments(
73-
effecitve_config_values=ScopeConfig({"name": "test"})
73+
effective_config_values=ScopeConfig({"name": "test"})
7474
)
7575
file_contents = PipelineFileContents.read_from_file(
7676
Path("tests/unit/pipeline/fixtures/config_pipeline.yaml")

0 commit comments

Comments
 (0)