Merge pull request #434 from nodestream-proj/LoggingMetrics

Spelling mistake fix, along with reducing the logging level of missing storage messages.

Author: zprobst

nodestream/cli/operations/initialize_logger.py

@@ -4,8 +4,9 @@
 
 from pythonjsonlogger.jsonlogger import JsonFormatter
 
-from ...metrics import Metrics
-from ..commands.nodestream_command import NodestreamCommand
+from nodestream.cli.commands.nodestream_command import NodestreamCommand
+from nodestream.metrics import Metrics
+
 from .operation import Operation
 
 

nodestream/pipeline/object_storage.py

@@ -253,7 +253,7 @@ class NullObjectStore(ObjectStore, alias="null"):
     """An object store that does not store any objects."""
 
     def __init__(self):
-        logger.error("Using null ObjectStore. No persistence is configured.")
+        logger.info("Using null ObjectStore. No persistence is configured.")
 
     def get(self, _: str) -> Optional[bytes]:
         return None

nodestream/pipeline/pipeline_file_loader.py

@@ -52,7 +52,7 @@ class PipelineInitializationArguments:
     annotations: Optional[List[str]] = None
     on_effective_configuration_resolved: Optional[Callable[[List[Dict]], None]] = None
     extra_steps: Optional[List[Step]] = None
-    effecitve_config_values: Optional[ScopeConfig] = None
+    effective_config_values: Optional[ScopeConfig] = None
     object_store: ObjectStore = field(default_factory=ObjectStore.null)
 
     @classmethod
@@ -145,7 +145,7 @@ def __init__(self, step_definitions: List[StepDefinition]) -> None:
         self.step_definitions = step_definitions
 
     def initialize_with_arguments(self, init_args: PipelineInitializationArguments):
-        with set_config(init_args.effecitve_config_values):
+        with set_config(init_args.effective_config_values):
             steps_defined_in_file = [
                 step_definition.load_step()
                 for step_definition in self.step_definitions

nodestream/project/run_request.py

@@ -56,4 +56,4 @@ async def execute_with_definition(self, definition: PipelineDefinition):
         await pipeline.run(self.progress_reporter)
 
     def set_configuration(self, scope_config: ScopeConfig):
-        self.initialization_arguments.effecitve_config_values = scope_config
+        self.initialization_arguments.effective_config_values = scope_config

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "nodestream"
-version = "0.14.14"
+version = "0.14.15"
 description = "A Fast, Declarative ETL for Graph Databases."
 license = "GPL-3.0-only"
 authors = [

tests/unit/pipeline/test_pipeline_file.py

@@ -70,7 +70,7 @@ def test_pipeline_file_loads_lazy():
 
 def test_pipeline_file_loads_config_when_set():
     init_args = PipelineInitializationArguments(
-        effecitve_config_values=ScopeConfig({"name": "test"})
+        effective_config_values=ScopeConfig({"name": "test"})
     )
     file_contents = PipelineFileContents.read_from_file(
         Path("tests/unit/pipeline/fixtures/config_pipeline.yaml")