Enhancement: Validate parameters for nil on noir.util.crypt's compare

[ricardojmendez]

Calling:

(compare nil (encrypt "hello"))

returns false as expected. However, calling

(compare "hello" nil)

raises a NullPointerException from org.mindrot.jbcrypt.BCrypt.hashpw. It would be better to validate both parameters before passing them down to BCrypt/checkpw, and return false if one of them is nil.

[yogthos]

good idea, updated the logic with the check

[yogthos]

also just a heads up, I've been meaning to do this for a while and I'm finally moving lib-noir to use Scrypt as Bcrypt hasn't been updated since 2010.

[ricardojmendez]

Thanks for the heads up, but no problem - not relying on any specific Bcrypt behavior. Cheers!