add libbacktrace

Author: noisecode3

.github/workflows/codacy.yml

@@ -34,23 +34,13 @@ jobs:
     name: Codacy Security Scan
     runs-on: ubuntu-latest
     steps:
-        # Install dependencies required for `ueberzug`
-      - name: Install system dependencies
-        run: sudo apt-get update && sudo apt-get install -y libxres-dev
-
       # Checkout the repository to the GitHub Actions runner
       - name: Checkout code
-        uses: actions/checkout@v3
-
-      # Install dependencies
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt
+        uses: actions/checkout@main
 
       # Execute Codacy Analysis CLI and generate a SARIF output with the security issues identified during the analysis
       - name: Run Codacy Analysis CLI
-        uses: codacy/codacy-analysis-cli-action@d840f886c4bd4edc059706d09c6a1586111c540b
+        uses: codacy/codacy-analysis-cli-action@master
         with:
           # Check https://github.com/codacy/codacy-analysis-cli#project-token to get your project token from your Codacy repository
           # You can also omit the token and run the tools that support default configurations
@@ -66,6 +56,6 @@ jobs:
 
       # Upload the SARIF file generated in the previous step
       - name: Upload SARIF results file
-        uses: github/codeql-action/upload-sarif@v3
+        uses: github/codeql-action/upload-sarif@main
         with:
           sarif_file: results.sarif

.gitmodules

@@ -4,3 +4,6 @@
 [submodule "libs/LIEF"]
 	path = libs/LIEF
 	url = https://github.com/lief-project/LIEF
+[submodule "libs/libbacktrace"]
+	path = libs/libbacktrace
+	url = https://github.com/ianlancetaylor/libbacktrace

README.md

@@ -102,6 +102,7 @@ sudo zypper install python3-pycurl python3-tqdm python3-cryptography python3-bea
 ```shell
 sudo apk add py3-pycurl py3-tqdm py3-cryptography py3-beautifulsoup4 py3-pillow
 ```
+
 Use the -sc flag to sync to trle
 
 ```shell
@@ -139,6 +140,7 @@ I tested the original, unpatched Tomb Raider III on an i7-4800MQ using its integ
 ```shell
 WINEPREFIX="/home/noisecode3/.newtombprefix" PROTONPATH="/home/noisecode3/.steam/steam/compatibilitytools.d/GE-Proton10-10" GAMEID="225320" MESA_SHADER_CACHE="true"
 ```
+
 It ran nearly perfectly — only a tiny framedrop once per hour, or sometimes not at all. Timing jitter caused by Wine’s threading system is largely eliminated under NTSync.
 NTSync can help DDraw, DirectSound other I/O thread workers in wine. On Arch Linux (or other distros with a modular kernel), you’ll need to manually load the ntsync driver to enable proper synchronization support:
 

libs/libbacktrace

@@ -26,6 +26,11 @@ int LevelListModel::rowCount(const QModelIndex &parent) const {
     return parent.isValid() ? 0 : m_levels.size();
 }
 
+void LevelListModel::setInstalled(const QModelIndex &index) {
+    ListItemData &item = *m_levels[index.row()];
+    item.m_installed = true;
+}
+
 QVariant LevelListModel::data(const QModelIndex &index, int role) const {
     QVariant result;
 
@@ -41,45 +46,56 @@ QVariant LevelListModel::data(const QModelIndex &index, int role) const {
 }
 
 void LevelListModel::setScrollChange(const quint64 index) {
-    m_scrollCoversCursorChanged = true;
-    m_scrollCoversCursor = index;
+    if (!m_levels.empty()) {
+        m_scrollCursorChanged = true;
+        m_seq_cursor_a = m_cursor_a.row();
+
+        quint64 size = m_levels.size();
+        quint64 i = qMin(index, size);
+        m_cursor_a = this->index(i, 0);
+    }
 }
 
 QVector<QSharedPointer<ListItemData>> LevelListModel::getDataBuffer(quint64 items) {
     QVector<QSharedPointer<ListItemData>> buffer;
 
     if ((items > 0) && !m_levels.isEmpty()) {
         quint64 size = m_levels.size();
-        quint64 index_a;
-        quint64 index_b;
-
-        if (m_scrollCoversCursorChanged) {
-            m_scrollCoversCursorChanged = false;
-            index_a = m_scrollCoversCursor;
-            index_b = qMin(m_scrollCoversCursor + items, size);
-            m_scrollCoversCursor = index_b;
-        } else {
-            index_a = m_sequentialCoversCursor;
-            index_b = qMin(m_sequentialCoversCursor + items, size);
-            m_sequentialCoversCursor = index_b;
-        }
+        // m_cursor_a starts on -1
+        // there is no way to inialize it
+        quint64 a = m_cursor_a.row() + 1;
+        quint64 b = qMin(a + items, size);
 
-        buffer.reserve(index_b - index_a);
-        for (quint64 i = index_a; i < index_b; ++i) {
+        m_cursor_b = this->index(b, 0);
+
+        buffer.reserve(b - a);
+        for (quint64 i = a; i < b; ++i) {
             buffer.append(m_levels[i]);
         }
     }
 
-    beginResetModel();
     return buffer;
 }
 
 void LevelListModel::reset() {
-    endResetModel();
+    if (m_cursor_a.isValid() && m_cursor_b.isValid()) {
+        emit dataChanged(m_cursor_a, m_cursor_b);
+    }
+
+    if (m_scrollCursorChanged == true) {
+        m_cursor_a = this->index(m_seq_cursor_a, 0);
+        m_scrollCursorChanged = false;
+    } else {
+        m_cursor_a = this->index(m_cursor_b.row(), 0);
+    }
 }
 
 bool LevelListModel::stop() {
-    return (m_sequentialCoversCursor == m_levels.size());
+    bool status = false;
+    if (m_scrollCursorChanged == false) {
+        status = (m_cursor_b.row() >= m_levels.size());
+    }
+    return status;
 }
 
 quint64 LevelListProxy::getLid(const QModelIndex &i) {

src/LevelViewList.cpp

@@ -29,9 +29,8 @@ class LevelListModel : public QAbstractListModel {
  public:
     explicit LevelListModel(QObject *parent = nullptr)
         : QAbstractListModel(parent),
-        m_scrollCoversCursor(0),
-        m_sequentialCoversCursor(0),
-        m_scrollCoversCursorChanged(false),
+        m_scrollCursorChanged(false),
+        m_seq_cursor_a(0),
         m_roleTable({
             { Qt::DisplayRole,  [](const ListItemData &i){ return i.m_title; }},
             { Qt::UserRole+1,   [](const ListItemData &i){ return i.m_game_id; }},
@@ -48,9 +47,10 @@ class LevelListModel : public QAbstractListModel {
         })
     {}
 
+    QVector<QSharedPointer<ListItemData>> getDataBuffer(const quint64 items);
     void setLevels(const QVector<QSharedPointer<ListItemData>>& levels);
     void setScrollChange(const quint64 index);
-    QVector<QSharedPointer<ListItemData>> getDataBuffer(const quint64 items);
+    void setInstalled(const QModelIndex &index);
     bool stop();
     void reset();
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
@@ -59,9 +59,10 @@ class LevelListModel : public QAbstractListModel {
  private:
     const QHash<int, std::function<QVariant(const ListItemData&)>> m_roleTable;
     QVector<QSharedPointer<ListItemData>> m_levels;
-    bool m_scrollCoversCursorChanged;
-    quint64 m_scrollCoversCursor;
-    quint64 m_sequentialCoversCursor;
+    bool m_scrollCursorChanged;
+    quint64 m_seq_cursor_a;
+    QModelIndex m_cursor_a;
+    QModelIndex m_cursor_b;
 };
 
 

src/LevelViewList.hpp

@@ -15,7 +15,6 @@
 #include "ui_TombRaiderLinuxLauncher.h"
 #include <QLineEdit>
 
-
 TombRaiderLinuxLauncher::TombRaiderLinuxLauncher(QWidget *parent)
     : QMainWindow(parent) {
     ui = new Ui::TombRaiderLinuxLauncher;
@@ -137,8 +136,7 @@ TombRaiderLinuxLauncher::TombRaiderLinuxLauncher(QWidget *parent)
         ui->listViewLevels->verticalScrollBar(),
         &QScrollBar::valueChanged,
         this,
-        &TombRaiderLinuxLauncher::levelListScrolled
-    );
+        &TombRaiderLinuxLauncher::levelListScrolled);
 
     connect(ui->checkBoxInstalled, &QCheckBox::toggled,
             levelListProxy, &LevelListProxy::setInstalledFilter);
@@ -167,6 +165,21 @@ TombRaiderLinuxLauncher::TombRaiderLinuxLauncher(QWidget *parent)
     }
 }
 
+void TombRaiderLinuxLauncher::setList() {
+    QVector<QSharedPointer<ListItemData>> list;
+    controller.getList(&list);
+    InstalledStatus installedStatus = getInstalled();
+
+    for (const auto &item : list) {
+        Q_ASSERT(item != nullptr);
+        bool trle = installedStatus.trle.value(item->m_trle_id, false);
+        item->m_installed = trle;
+    }
+
+    levelListModel->setLevels(list);
+    loadMoreCovers();
+}
+
 void TombRaiderLinuxLauncher::generateList(const QList<int>& availableGames) {
     // Update list only when 24 hours past
     QDateTime now = QDateTime::currentDateTime();
@@ -191,31 +204,27 @@ void TombRaiderLinuxLauncher::generateList(const QList<int>& availableGames) {
         settings.setValue("lastUpdated", now.toString(Qt::ISODate));
         m_availableGames = availableGames;
     } else {
-        QVector<QSharedPointer<ListItemData>> list;
-        controller.getList(&list);
-        levelListModel->setLevels(list);
-        setInstalled();
-        loadMoreCovers();
+        setList();
         ui->stackedWidget->setCurrentWidget(
             ui->stackedWidget->findChild<QWidget*>("select"));
     }
 }
 
-void TombRaiderLinuxLauncher::setInstalled() {
+InstalledStatus TombRaiderLinuxLauncher::getInstalled() {
     QStringList keys = settings.allKeys();
-    QHash<int, bool> installedLevel;
-    QHash<int, bool> installedGame;
+    InstalledStatus list;
     for (const auto &key : std::as_const(keys)) {
         if (key.startsWith("installed/game")) {
-            qint64 id = key.midRef(QString("installed/game").length()).toInt();
-            installedGame.insert(id, settings.value(key).toBool());
+            quint64 id =
+                    key.midRef(QString("installed/game").length()).toUInt();
+            list.game.insert(id, settings.value(key).toBool());
         } else if (key.startsWith("installed/level")) {
-            qint64 id = key.midRef(QString("installed/level").length()).toInt();
-            installedLevel.insert(id, settings.value(key).toBool());
+            quint64 id =
+                    key.midRef(QString("installed/level").length()).toUInt();
+            list.trle.insert(id, settings.value(key).toBool());
         }
     }
-    // levelListModel->setInstalledListOriginal(installedGame);
-    // levelListModel->setInstalledList(installedLevel);
+    return list;
 }
 
 bool TombRaiderLinuxLauncher::setStartupSetting(const StartupSetting settings) {
@@ -509,7 +518,7 @@ void TombRaiderLinuxLauncher::downloadClicked() {
 void TombRaiderLinuxLauncher::infoClicked() {
     QModelIndex current = ui->listViewLevels->currentIndex();
     if (current.isValid()) {
-        qint64 id = levelListProxy->getLid(current);   // getLid(current);
+        qint64 id = levelListProxy->getLid(current);  // getLid(current);
         if (id != 0) {
             InfoData info = controller.getInfo(id);
             if (info.m_body == "" && info.m_imageList.size() == 0) {
@@ -597,7 +606,8 @@ void TombRaiderLinuxLauncher::loadMoreCovers() {
         levelListModel->reset();
     }
     if (!levelListModel->stop()) {
-        QVector<QSharedPointer<ListItemData>> buffer = levelListModel->getDataBuffer(100);
+        QVector<QSharedPointer<ListItemData>> buffer =
+                levelListModel->getDataBuffer(100);
         if (!buffer.isEmpty()) {
             controller.getCoverList(buffer);
         } else {
@@ -631,8 +641,8 @@ void TombRaiderLinuxLauncher::workTick() {
         QModelIndex current = ui->listViewLevels->currentIndex();
         if (current.isValid()) {
             qint64 id = levelListProxy->getLid(current);
-            //levelListProxy->setInstalled(current);
-            if (levelListProxy->getItemType(current)) {  // its the original game
+            levelListModel->setInstalled(current);
+            if (levelListProxy->getItemType(current)) {
                 settings.setValue(
                         QString("installed/game%1").arg(id),
                         "true");
@@ -679,11 +689,7 @@ void TombRaiderLinuxLauncher::downloadError(int status) {
 void TombRaiderLinuxLauncher::UpdateLevelDone() {
     m_loadingIndicatorWidget->hide();
     if (m_loadingDoneGoTo == "select") {
-        QVector<QSharedPointer<ListItemData>> list;
-        controller.getList(&list);
-        levelListModel->setLevels(list);
-        setInstalled();
-        loadMoreCovers();
+        setList();
         ui->stackedWidget->setCurrentWidget(
             ui->stackedWidget->findChild<QWidget*>("select"));
     } else if (m_loadingDoneGoTo == "info") {

src/TombRaiderLinuxLauncher.cpp

@@ -33,6 +33,11 @@
 #include "../src/LevelViewList.hpp"
 #include "../src/LoadingIndicator.hpp"
 
+struct InstalledStatus {
+    QHash<quint64, bool> game;
+    QHash<quint64, bool> trle;
+};
+
 QT_BEGIN_NAMESPACE
 namespace Ui { class TombRaiderLinuxLauncher; }
 QT_END_NAMESPACE
@@ -152,7 +157,12 @@ class TombRaiderLinuxLauncher : public QMainWindow {
     /**
      * 
      */
-    void setInstalled();
+    void setList();
+
+    /**
+     * 
+     */
+    InstalledStatus getInstalled();
 
     /**
      *