Sort filter cleanup

* implementing sorting and filter with QSortFilterProxyModel

pictures should load where the scrolling position of list is at first then in some sequential order, also if filtering and sorting takes place early then we must update the pictures at scrolling position

* fix crash if exiting the app before loading all covers

* update at scroll position

* fix some bugs

* fix some commandline startup options

* add libbacktrace

* set codacy version

* fix LevelListProxy::getItemType logic

* update to QT6

* fix the signal logic

Author: noisecode3

.github/workflows/codacy.yml

@@ -34,23 +34,13 @@ jobs:
     name: Codacy Security Scan
     runs-on: ubuntu-latest
     steps:
-        # Install dependencies required for `ueberzug`
-      - name: Install system dependencies
-        run: sudo apt-get update && sudo apt-get install -y libxres-dev
-
       # Checkout the repository to the GitHub Actions runner
       - name: Checkout code
         uses: actions/checkout@v3
 
-      # Install dependencies
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt
-
       # Execute Codacy Analysis CLI and generate a SARIF output with the security issues identified during the analysis
       - name: Run Codacy Analysis CLI
-        uses: codacy/codacy-analysis-cli-action@d840f886c4bd4edc059706d09c6a1586111c540b
+        uses: codacy/codacy-analysis-cli-action@releases/v4
         with:
           # Check https://github.com/codacy/codacy-analysis-cli#project-token to get your project token from your Codacy repository
           # You can also omit the token and run the tools that support default configurations

.gitmodules

@@ -4,3 +4,6 @@
 [submodule "libs/LIEF"]
 	path = libs/LIEF
 	url = https://github.com/lief-project/LIEF
+[submodule "libs/libbacktrace"]
+	path = libs/libbacktrace
+	url = https://github.com/ianlancetaylor/libbacktrace

CMakeLists.txt

@@ -14,33 +14,37 @@ else()
     set(CMAKE_BUILD_TYPE Release)
 endif()
 
-find_package(Qt5 COMPONENTS Core Gui Test Widgets WebEngineWidgets Sql REQUIRED)
+find_package(Qt6 COMPONENTS Core Gui Test Widgets WebEngineWidgets Sql REQUIRED)
 
 find_package(CURL REQUIRED)
 
+# Add miniz as a subdirectory
 if(NOT EXISTS "${CMAKE_SOURCE_DIR}/libs/miniz/CMakeLists.txt")
     message(STATUS "Submodule 'libs/miniz' not found. Updating submodules...")
     execute_process(
         COMMAND git submodule update --init --recursive
         WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
     )
-    file(READ "${CMAKE_SOURCE_DIR}/libs/miniz/CMakeLists.txt" cmake)
+    file(READ "${CMAKE_SOURCE_DIR}/libs/miniz/CMakeLists.txt" MINIZ_CMAKE)
     string(REPLACE "cmake_minimum_required(VERSION 3.5)"
-        "cmake_minimum_required(VERSION 3.16)" my_cmake "${cmake}")
-    file(WRITE "${CMAKE_SOURCE_DIR}/libs/miniz/CMakeLists.txt" "${my_cmake}")
-endif()
-
-if(NOT EXISTS "${CMAKE_SOURCE_DIR}/database/tombll.db")
-    message(STATUS "Database not found, running get_trle.sh...")
-    execute_process(
-        COMMAND bash "${CMAKE_SOURCE_DIR}/database/get_trle.sh"
-        WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}"
+        "cmake_minimum_required(VERSION 3.16)"
+        NEW_MINIZ_CMAKE
+        "${MINIZ_CMAKE}"
+    )
+    file(WRITE "${CMAKE_SOURCE_DIR}/libs/miniz/CMakeLists.txt"
+        "${NEW_MINIZ_CMAKE}"
     )
 endif()
-
 add_subdirectory(libs/miniz)
 
 # Add LIEF as a subdirectory
+if(NOT EXISTS "${CMAKE_SOURCE_DIR}/libs/LIEF/CMakeLists.txt")
+    message(STATUS "Submodule 'libs/LIEF' not found. Updating submodules...")
+    execute_process(
+        COMMAND git submodule update --init --recursive
+        WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+    )
+endif()
 set(LIEF_INSTALL OFF CACHE BOOL "Disable installation of LIEF")
 set(LIEF_EXAMPLES OFF)
 set(LIEF_TESTS OFF)
@@ -51,29 +55,60 @@ set(LIEF_PE ON)
 set(LIEF_MACHO OFF)
 set(LIEF_DEX OFF)
 set(LIEF_ART OFF)
+add_subdirectory(libs/LIEF)
 
-if(NOT EXISTS "${CMAKE_SOURCE_DIR}/libs/LIEF/CMakeLists.txt"
-        AND NOT NO_DATABASE
+# Add libbacktrace as a subdirectory
+if(NOT EXISTS "${CMAKE_SOURCE_DIR}/libs/libbacktrace/configure")
+    message(STATUS
+        "Submodule 'libs/libbacktrace' not found. Updating submodules..."
     )
-    message(STATUS "Submodule 'libs/LIEF' not found. Updating submodules...")
     execute_process(
         COMMAND git submodule update --init --recursive
         WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
     )
 endif()
+if(EXISTS "${CMAKE_SOURCE_DIR}/libs/libbacktrace/configure")
+    message(STATUS "Running autoconf to prepare libbacktrace")
+    execute_process(
+        COMMAND bash "${CMAKE_SOURCE_DIR}/libs/libbacktrace/configure"
+        WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/libs/libbacktrace"
+        RESULT_VARIABLE AUTOCONF_RESULT
+    )
+    if(NOT AUTOCONF_RESULT EQUAL 0)
+        message(
+            FATAL_ERROR
+            "Autoconf failed with exit code ${AUTOCONF_RESULT}"
+        )
+    endif()
+    execute_process(
+        COMMAND make
+        WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/libs/libbacktrace"
+        RESULT_VARIABLE MAKE_RESULT
+    )
+    if(NOT MAKE_RESULT EQUAL 0)
+        message(
+            FATAL_ERROR
+            "Make failed with exit code ${MAKE__RESULT}"
+        )
+    endif()
+endif()
 
-add_subdirectory(libs/LIEF)
 
-# Update submodules if we forget
-# git submodule update --init --recursive
-# git submodule update --remote --merge
-# git submodule sync # (optional) if URL change
+if(NOT EXISTS "${CMAKE_SOURCE_DIR}/database/tombll.db")
+    message(STATUS "Database not found, running get_trle.sh...")
+    execute_process(
+        COMMAND bash "${CMAKE_SOURCE_DIR}/database/get_trle.sh"
+        WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}"
+    )
+endif()
 
 set(SOURCES_TESTS
     test/test.hpp
 )
 
 set(SOURCES_MC
+    src/CommandLineParser.hpp
+    src/CommandLineParser.cpp
     src/Controller.hpp
     src/Controller.cpp
     src/Data.hpp
@@ -82,6 +117,8 @@ set(SOURCES_MC
     src/FileManager.cpp
     src/GameFileTree.hpp
     src/GameFileTree.cpp
+    src/LevelViewList.hpp
+    src/LevelViewList.cpp
     src/LoadingIndicator.hpp
     src/LoadingIndicator.cpp
     src/Model.hpp
@@ -94,9 +131,9 @@ set(SOURCES_MC
     src/PyRunner.hpp
     src/Runner.cpp
     src/Runner.hpp
+    src/assert.hpp
     src/binary.hpp
     src/binary.cpp
-    src/levelViewList.hpp
     src/main.cpp
     src/staticData.hpp
 )
@@ -109,23 +146,25 @@ set(SOURCES_VIEW
 )
 
 set(LINK_COMMON
-    Qt5::Core
-    Qt5::Widgets
-    Qt5::WebEngineWidgets
-    Qt5::Sql
+    Qt6::Core
+    Qt6::Widgets
+    Qt6::WebEngineWidgets
+    Qt6::Sql
     miniz
     LIEF::LIEF
     ${CURL_LIBRARY}
+    "${CMAKE_SOURCE_DIR}/libs/libbacktrace/.libs/libbacktrace.a"
 )
 
 set(LINK_GUI
-    Qt5::Gui
+    Qt6::Gui
 )
 
 set(INCLUDE_DIR
     ${CURL_INCLUDE_DIR}
     libs/miniz
     libs/LIEF/include
+    libs/libbacktrace
     src
 )
 
@@ -137,7 +176,7 @@ if(TEST)
     set(SOURCES ${SOURCES_MC} ${SOURCES_TESTS})
     add_executable(${PROJECT_NAME}Test ${SOURCES})
     add_test(NAME ${PROJECT_NAME}Test COMMAND ${PROJECT_NAME}Test)
-    target_link_libraries(${PROJECT_NAME}Test PUBLIC ${LINK_COMMON} Qt5::Test)
+    target_link_libraries(${PROJECT_NAME}Test PUBLIC ${LINK_COMMON} Qt6::Test)
     target_include_directories(${PROJECT_NAME}Test PRIVATE ${INCLUDE_DIR} test)
     target_compile_definitions(${PROJECT_NAME}Test PRIVATE TEST)
     set_target_properties(${PROJECT_NAME}Test PROPERTIES

README.md

@@ -102,6 +102,7 @@ sudo zypper install python3-pycurl python3-tqdm python3-cryptography python3-bea
 ```shell
 sudo apk add py3-pycurl py3-tqdm py3-cryptography py3-beautifulsoup4 py3-pillow
 ```
+
 Use the -sc flag to sync to trle
 
 ```shell
@@ -139,6 +140,7 @@ I tested the original, unpatched Tomb Raider III on an i7-4800MQ using its integ
 ```shell
 WINEPREFIX="/home/noisecode3/.newtombprefix" PROTONPATH="/home/noisecode3/.steam/steam/compatibilitytools.d/GE-Proton10-10" GAMEID="225320" MESA_SHADER_CACHE="true"
 ```
+
 It ran nearly perfectly — only a tiny framedrop once per hour, or sometimes not at all. Timing jitter caused by Wine’s threading system is largely eliminated under NTSync.
 NTSync can help DDraw, DirectSound other I/O thread workers in wine. On Arch Linux (or other distros with a modular kernel), you’ll need to manually load the ntsync driver to enable proper synchronization support:
 

libs/libbacktrace

@@ -15,5 +15,6 @@ cmake \
 cd ..
 
 git config submodule.libs/miniz.ignore all
+git config submodule.libs/libbacktrace.ignore all
 
 ./build.sh