ai perf: more2

Author: fchn289

src/domino/DataDomino.hpp

@@ -63,7 +63,7 @@ S_PTR<void> DataDomino<aDominoType>::getData(const Domino::EvName& aEvName) cons
 template<typename aDominoType>
 bool DataDomino<aDominoType>::replaceDataOK(const Domino::EvName& aEvName, S_PTR<void> aData) noexcept
 {
-    return ev_data_S_.replaceOK(this->newEvent(aEvName), aData);
+    return ev_data_S_.replaceOK(this->newEvent(aEvName), std::move(aData));
 }
 
 // ***********************************************************************************************

src/domino/RmEvDom.hpp

@@ -64,8 +64,9 @@ Domino::Event RmEvDom<aDominoType>::recycleEv_() noexcept
     if (isRemovedEv_.empty())
         return Domino::D_EVENT_FAILED_RET;
 
-    const auto ev = *(isRemovedEv_.begin());
-    isRemovedEv_.erase(ev);
+    const auto it = isRemovedEv_.begin();
+    const auto ev = *it;
+    isRemovedEv_.erase(it);  // erase by iterator to avoid second lookup
     return ev;
 }
 

src/log/StrCoutFSL.hpp

@@ -54,7 +54,7 @@ StrCoutFSL::~StrCoutFSL() noexcept
 inline
 void StrCoutFSL::forceSave() const noexcept
 {
-    std::cout << rdbuf() << std::endl;  // internet says rdbuf() is faster than str()
+    std::cout << rdbuf() << '\n';  // rdbuf() faster than str(); newline w/o flush faster than endl
 }
 
 }  // namespace

src/log/UniSmartLog.hpp

@@ -73,7 +73,7 @@ class UniSmartLog
         auto&& name_log = name_log_S_.find(aUniLogName);
         return name_log == name_log_S_.end()
             ? 0
-            : name_log->second->str().size();
+            : static_cast<size_t>(name_log->second->tellp());  // avoid str().size() which creates string copy
     }
 #endif
 };

src/obj_anywhere/DataStore.hpp

@@ -58,7 +58,7 @@ bool DataStore<aDataKey>::emplaceOK(const aDataKey& aKey, S_PTR<void> aData) noe
         }
         else
         {
-            if (key_data_S_.emplace(aKey, std::move(aData)).second)
+            if (key_data_S_.try_emplace(aKey, std::move(aData)).second)
                 return true;
             else
             {
@@ -99,7 +99,7 @@ bool DataStore<aDataKey>::replaceOK(const aDataKey& aKey, S_PTR<void> aData) noe
         if (! aData)
             return emplaceOK(aKey, nullptr);
 
-        key_data_S_[aKey] = std::move(aData);
+        key_data_S_.insert_or_assign(aKey, std::move(aData));
         return true;
     } catch(...) {
         ERR("(DataStore) except->failed!!! key=" << typeid(aDataKey).name());

src/obj_anywhere/ObjAnywhere.cpp

@@ -9,7 +9,7 @@ using namespace std;
 
 namespace rlib
 {
-shared_ptr<DataStore<ObjName>> ObjAnywhere::name_obj_S_;
+unique_ptr<DataStore<ObjName>> ObjAnywhere::name_obj_S_;
 
 // ***********************************************************************************************
 void ObjAnywhere::deinit() noexcept
@@ -24,7 +24,7 @@ void ObjAnywhere::init(UniLog& oneLog) noexcept
         WRN("(ObjAnywhere) !!! Refuse dup init.")
     else
     {
-        name_obj_S_ = make_shared<DataStore<ObjName>>();
+        name_obj_S_ = make_unique<DataStore<ObjName>>();
         HID("(ObjAnywhere) Succeed.");
     }
 }

src/obj_anywhere/ObjAnywhere.hpp

@@ -56,7 +56,7 @@ class ObjAnywhere
 
 private:
     // -------------------------------------------------------------------------------------------
-    static std::shared_ptr<DataStore<ObjName>> name_obj_S_;  // store aObj w/o include aObj.hpp; shared_ptr is safe here
+    static std::unique_ptr<DataStore<ObjName>> name_obj_S_;  // store aObj w/o include aObj.hpp; unique_ptr is safe here
 };
 
 // ***********************************************************************************************

src/thread/AsyncBack.cpp

@@ -24,11 +24,12 @@ bool AsyncBack::newTaskOK(const MT_TaskEntryFN& mt_aEntryFN, const TaskBackFN& a
                 launch::async,
                 // - must cp mt_aEntryFN than ref, otherwise dead loop
                 // - &mt_nDoneFut is better than "this" that can access other non-MT-safe member
-                [mt_aEntryFN, &mt_nDoneFut = mt_nDoneFut_]() noexcept  // thread main
+                [mt_aEntryFN = std::move(mt_aEntryFN), &mt_nDoneFut = mt_nDoneFut_]() mutable noexcept  // thread main
                 {
                     SafePtr ret;
                     try { ret = mt_aEntryFN(); }
                     catch(...) {}  // continue following
+                    mt_aEntryFN = nullptr;  // early release captured function
 
                     mt_nDoneFut.fetch_add(1, std::memory_order_relaxed);  // fastest +1
                     mt_pingMainTH();

src/thread/MT_PingMainTH.cpp

@@ -7,5 +7,5 @@
 
 namespace rlib
 {
-MT_Semaphore g_semToMainTH;
+alignas(64) MT_Semaphore g_semToMainTH;
 }  // namespace

src/thread/MT_Semaphore.cpp

@@ -17,7 +17,7 @@ void MT_Semaphore::mt_notify() noexcept
 {
     // - can't sem_getvalue() as NOT mt-safe
     // - mt_notified_ is to avoid sem counter overflow; & not rouse main-thread repeatedly
-    if (!mt_notified_.test_and_set())  // memory_order_seq_cst to ensure other thread(s) see the flag
+    if (!mt_notified_.test_and_set(std::memory_order_acquire))  // acquire: ensure sem_post visibility
         sem_post(&mt_sem_);  // impossible failed since MT_Semaphore's constructor
 }
 
@@ -34,9 +34,9 @@ void MT_Semaphore::timedwait(const size_t aSec, const size_t aRestNsec) noexcept
     for (;;)
     {
         const auto ret = sem_timedwait(&mt_sem_, &ts);
-        if (errno == ETIMEDOUT || ret == 0)  // timeout or notified -> wakeup to handle sth
+        if (ret == 0 || errno == ETIMEDOUT)  // notified or timeout -> wakeup to handle sth
         {
-            mt_notified_.clear();  // memory_order_seq_cst to ensure other thread(s) see the flag
+            mt_notified_.clear(std::memory_order_release);  // release: publish flag clear to other threads
             return;
         }