review fix

Author: marcin-usielski

moler/cmd/unix/iperf2.py

@@ -636,6 +636,7 @@ def has_any_result(self) -> bool:
         :return: True if current_ret has collected any data. Otherwise False.
         """
 
+        ret_value = False
         if not self._output_parsed:
             if '--version' in self.options:
                 was_version = any(self._regex_helper.search_compiled(Iperf2._re_version, line) for line in self.current_ret["INFO"])
@@ -644,8 +645,8 @@ def has_any_result(self) -> bool:
                 return was_version
             else:
                 self._output_parsed = True  # we don't exepect any specific data for this instance.
-            return super(Iperf2, self).has_any_result()
-        return False
+            ret_value = super(Iperf2, self).has_any_result()
+        return ret_value
 
 
 COMMAND_OUTPUT_version = """xyz@debian:~$ iperf --version

moler/cmd/unix/ping.py

@@ -109,7 +109,7 @@ def _parse_trans_recv_loss(self, line):
     # 7 packets transmitted, 7 received, +6 duplicates, 0% packet loss, time 6142ms
     # 4 packets transmitted, 3 received, +1 errors, 25% packet loss, time 3008ms
     _re_trans_recv_loss_time_plus_errors = re.compile(
-        r"(?P<PKTS_TRANS>\d+) packets transmitted, (?P<PKTS_RECV>\d+) received, \+?(?P<ERRORS>\d+) (?P<ERR_DUP>errors|duplicates), (?P<PKT_LOSS>\S+)% packet loss, time (?P<TIME>\d+)\s*(?P<UNIT>\w+)")
+        r"(?P<PKTS_TRANS>\d+) packets transmitted, (?P<PKTS_RECV>\d+) received, \+?(?P<ERR_DUP_VAL>\d+) (?P<ERR_DUP>errors|duplicates), (?P<PKT_LOSS>\S+)% packet loss, time (?P<TIME>\d+)\s*(?P<UNIT>\w+)")
 
     def _parse_trans_recv_loss_time_plus_errors(self, line):
         """
@@ -122,7 +122,7 @@ def _parse_trans_recv_loss_time_plus_errors(self, line):
                 self._regex_helper.group('PKTS_TRANS'))
             self.current_ret['packets_received'] = self._converter_helper.to_number(
                 self._regex_helper.group('PKTS_RECV'))
-            self.current_ret[self._regex_helper.group('ERR_DUP')] = self._converter_helper.to_number(self._regex_helper.group('ERRORS'))
+            self.current_ret[self._regex_helper.group('ERR_DUP')] = self._converter_helper.to_number(self._regex_helper.group('ERR_DUP_VAL'))
             self.current_ret['packet_loss'] = self._converter_helper.to_number(self._regex_helper.group('PKT_LOSS'))
             self.current_ret['time'] = self._converter_helper.to_number(self._regex_helper.group('TIME'))
             self.current_ret['packets_time_unit'] = self._regex_helper.group('UNIT')