Skip to content

Commit f4ca5ce

Browse files
helltCopilot
andauthored
Updated testing matrix and added ansible 2.18 and 2.19 (#36)
* updated testing matrix and added ansible 2.18 and 2.19 * use py 3.13 for 2.19.5 * adapt for different error handling in ansible 2.19 * test for ansible 2.19 and earlier * trying things * use jinja concat instead of embedding templates * added from_json * load golden cfg * use template iso file * convert to json * from json * conditional config_content mapping * fix conditional for 2.19 * Update galaxy.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * drop 2.15 and set 2.16 as a minimal version * removing old sanity tests * remove import/compile-3.5 * added changelog, bumped srl version * update cfg for 25.10 * peak packet rate for 25.10 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent ee912fe commit f4ca5ce

24 files changed

+72
-245
lines changed

.github/container-matrix.yml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,6 @@
99
# python version are taken from ansible's support matrix - https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#support-life
1010
# ansible-core-image version is taken from https://github.com/orgs/srl-labs/packages?repo_name=ansible-core
1111
include:
12-
# 2.14
13-
- ansible-core-image: "2.14.17:pypy3.10"
14-
runs-on: "ubuntu-22.04"
15-
16-
- ansible-core-image: "2.14.17:py3.11"
17-
runs-on: "ubuntu-22.04"
18-
addional-tags: "latest"
19-
20-
# 2.15
21-
- ansible-core-image: "2.15.12:pypy3.10"
22-
runs-on: "ubuntu-22.04"
23-
24-
- ansible-core-image: "2.15.12:py3.11"
25-
runs-on: "ubuntu-22.04"
26-
27-
- ansible-core-image: "2.15.12:py3.12"
28-
runs-on: "ubuntu-22.04"
29-
addional-tags: "latest"
30-
3112
# 2.16
3213
- ansible-core-image: "2.16.8:pypy3.10"
3314
runs-on: "ubuntu-22.04"

.github/matrix.yml

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,9 @@
77
# support matrix for ansible control node - https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html#node-requirement-summary
88

99
include:
10-
####################
11-
# Python 3.9
12-
####################
13-
- &latest-2_14
14-
ansible-core-version: "2.14.17"
15-
runs-on: "ubuntu-22.04"
16-
python-version: "3.9"
17-
18-
- &latest-2_15
19-
ansible-core-version: "2.15.12"
20-
runs-on: "ubuntu-22.04"
21-
python-version: "3.9"
22-
2310
####################
2411
# Python 3.10
2512
####################
26-
27-
- <<: *latest-2_14
28-
python-version: "3.10"
29-
30-
- <<: *latest-2_15
31-
python-version: "3.10"
32-
3313
- &latest-2_16
3414
ansible-core-version: "2.16.8"
3515
runs-on: "ubuntu-22.04"
@@ -43,13 +23,6 @@ include:
4323
####################
4424
# Python 3.11
4525
####################
46-
47-
- <<: *latest-2_14
48-
python-version: "3.11"
49-
50-
- <<: *latest-2_15
51-
python-version: "3.11"
52-
5326
- <<: *latest-2_16
5427
python-version: "3.11"
5528

@@ -59,11 +32,18 @@ include:
5932
####################
6033
# Python 3.12
6134
####################
62-
- <<: *latest-2_15
63-
python-version: "3.12"
64-
6535
- <<: *latest-2_16
6636
python-version: "3.12"
6737

6838
- <<: *latest-2_17
6939
python-version: "3.12"
40+
41+
- &latest-2_18
42+
ansible-core-version: "2.18.12"
43+
runs-on: "ubuntu-24.04"
44+
python-version: "3.12"
45+
46+
- &latest-2_19
47+
ansible-core-version: "2.19.5"
48+
runs-on: "ubuntu-24.04"
49+
python-version: "3.13"

.github/workflows/cicd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ jobs:
9797
python-version: 3.11
9898

9999
- name: Install ansible core
100-
run: pip install ansible-core==2.15.12
100+
run: pip install ansible-core==2.16.12
101101

102102
- name: Ansible sanity test
103103
run: ./run.sh sanity-test

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,8 @@
2828
### Chores
2929

3030
* Removed unused artifacts from the build.
31+
32+
## v1.1.0
33+
34+
* Removed ansible-core 2.15 support, added support for ansible-core 2.18 and 2.19.
35+
* Removed upper-bound restrictions on `ansible.utils` and `ansible.netcommon` versions.

galaxy.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace: nokia
1212
name: srlinux
1313

1414
# The version of the collection. Must be compatible with semantic versioning
15-
version: 1.0.3
15+
version: 1.1.0
1616

1717
# The path to the Markdown (.md) readme file. This path is relative to the root of the collection
1818
readme: README.md
@@ -45,10 +45,10 @@ tags:
4545
# collection label 'namespace.name'. The value is a version range
4646
# L(specifiers,https://python-semanticversion.readthedocs.io/en/latest/#requirement-specification). Multiple version
4747
# range specifiers can be set and are separated by ','
48-
# fixed dependencies on ansible.netcommon and ansible.utils since newer versions drop support for ansible core 2.14. We can go to the latest version of these deps later
48+
# Minimum required versions of ansible.netcommon and ansible.utils for this collection.
4949
dependencies:
50-
"ansible.netcommon": ">=5.2.0,<=6.1.3"
51-
"ansible.utils": ">=3.0.0,<5.0.0"
50+
"ansible.netcommon": ">=5.2.0"
51+
"ansible.utils": ">=3.0.0"
5252

5353
# The URL of the originating SCM repository
5454
repository: https://github.com/nokia/srlinux-ansible-collection

meta/runtime.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
requires_ansible: ">=2.15.0"
1+
requires_ansible: ">=2.16.0"
22
plugin_routing:
33
modules:
44
srl_config:

pyproject.toml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
[project]
22
name = "srlinux-ansible-collection"
3-
version = "1.0.1"
3+
version = "1.1.0"
44
description = "SR Linux Ansible Collection"
55
readme = "README.md"
66
requires-python = ">=3.11"
7-
dependencies = ["ansible-core==2.16.2"]
7+
dependencies = [
8+
"ansible-core==2.16.12",
9+
"pyyaml",
10+
]
811

912
[dependency-groups]
10-
dev = [
11-
"rich>=13.9.4",
12-
"ruff>=0.9.4",
13-
]
13+
dev = ["rich>=13.9.4", "ruff>=0.9.4"]

run.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -354,12 +354,12 @@ function ci-test {
354354
ANSIBLE_CONFIG=ci-ansible.cfg _run-tests "$@"
355355
}
356356

357-
# copy sanity ignore files from ignore-2.10.txt to all other supported ansible versions
357+
# copy sanity ignore files from ignore-2.16.txt to all other supported ansible versions
358358
function copy-sanity-ignore {
359359
_cdTests
360360
cd sanity
361-
for version in 2.14 2.15 2.16 2.17; do
362-
cp ignore-2.10.txt ignore-${version}.txt
361+
for version in 2.17 2.18 2.19; do
362+
cp ignore-2.16.txt ignore-${version}.txt
363363
done
364364
}
365365

scripts/topo.clab.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ topology:
88
nodes:
99
srl:
1010
kind: nokia_srlinux
11-
image: ghcr.io/nokia/srlinux:${SRLINUX_VERSION:=24.10.1}
11+
image: ghcr.io/nokia/srlinux:${SRLINUX_VERSION:=25.10}
1212
mgmt-ipv4: 172.20.20.222

tests/playbooks/golden/clab-ansible-srl-golden.cfg.json.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1577,9 +1577,9 @@
15771577
"system-cpu-policer": [
15781578
{
15791579
"entry-specific": false,
1580-
"max-packet-burst": 1000,
1580+
"maximum-burst-packet": 1000,
15811581
"name": "icmp",
1582-
"peak-packet-rate": 1000
1582+
"peak-rate-pps": 1000
15831583
}
15841584
]
15851585
}

0 commit comments

Comments
 (0)