Fix tests and depcreation warnings

Author: djm81

src/specfact_cli/analyzers/ambiguity_scanner.py

@@ -910,12 +910,8 @@ def _extract_target_users(self, plan_bundle: PlanBundle) -> list[str]:
                                                             # Look for role/permission constants (e.g., ADMIN = "admin")
                                                             if (
                                                                 "role" in attr_name or "permission" in attr_name
-                                                            ) and isinstance(item.value, (ast.Str, ast.Constant)):
-                                                                role_value = (
-                                                                    item.value.s
-                                                                    if isinstance(item.value, ast.Str)
-                                                                    else item.value
-                                                                )
+                                                            ) and isinstance(item.value, ast.Constant):
+                                                                role_value = item.value.value
                                                                 if isinstance(role_value, str) and len(role_value) > 2:
                                                                     role_clean = role_value.strip().lower()
                                                                     if (

src/specfact_cli/validators/sidecar/crosshair_summary.py

@@ -189,10 +189,10 @@ def generate_summary_file(
     Returns:
         Path to generated summary file
     """
-    from datetime import datetime
+    from datetime import UTC, datetime
 
     if timestamp is None:
-        timestamp = datetime.utcnow().strftime("%Y%m%dT%H%M%SZ")
+        timestamp = datetime.now(UTC).strftime("%Y%m%dT%H%M%SZ")
 
     # Ensure reports directory exists (creates parent directories if needed)
     reports_dir.mkdir(parents=True, exist_ok=True)

src/specfact_cli/validators/sidecar/frameworks/django.py

@@ -199,12 +199,9 @@ def _get_function_name(self, func_node: ast.AST) -> str:
 
     @beartype
     def _extract_string_literal(self, node: ast.AST) -> str | None:
-        """Extract string literal from AST node."""
-        if isinstance(node, ast.Constant):
-            if isinstance(node.value, str):
-                return node.value
-        elif hasattr(ast, "Str") and isinstance(node, ast.Str):
-            return node.s  # type: ignore[attr-defined, deprecated]
+        """Extract string literal from AST node (Python 3.8+ uses ast.Constant)."""
+        if isinstance(node, ast.Constant) and isinstance(node.value, str):
+            return node.value
         return None
 
     @beartype

src/specfact_cli/validators/sidecar/frameworks/fastapi.py

@@ -182,12 +182,9 @@ def _extract_route_from_function(
 
     @beartype
     def _extract_string_literal(self, node: ast.AST) -> str | None:
-        """Extract string literal from AST node."""
-        if isinstance(node, ast.Constant):
-            if isinstance(node.value, str):
-                return node.value
-        elif hasattr(ast, "Str") and isinstance(node, ast.Str):
-            return node.s  # type: ignore[attr-defined, deprecated]
+        """Extract string literal from AST node (Python 3.8+ uses ast.Constant)."""
+        if isinstance(node, ast.Constant) and isinstance(node.value, str):
+            return node.value
         return None
 
     @beartype

src/specfact_cli/validators/sidecar/frameworks/flask.py

@@ -222,12 +222,9 @@ def _extract_route_from_function(
 
     @beartype
     def _extract_string_literal(self, node: ast.AST) -> str | None:
-        """Extract string literal from AST node."""
-        if isinstance(node, ast.Constant):
-            if isinstance(node.value, str):
-                return node.value
-        elif hasattr(ast, "Str") and isinstance(node, ast.Str):
-            return node.s  # type: ignore[attr-defined, deprecated]
+        """Extract string literal from AST node (Python 3.8+ uses ast.Constant)."""
+        if isinstance(node, ast.Constant) and isinstance(node.value, str):
+            return node.value
         return None
 
     @beartype

tests/integration/sync/test_ado_backlog_sync.py

@@ -89,7 +89,13 @@ def test_openspec_to_ado_export(
         mock_patch.assert_called_once()
 
     @beartype
-    def test_ado_to_openspec_import(self, ado_adapter: AdoAdapter, tmp_path: Path) -> None:
+    @patch.object(AdoAdapter, "_get_work_item_comments", return_value=[])
+    def test_ado_to_openspec_import(
+        self,
+        mock_get_comments: MagicMock,
+        ado_adapter: AdoAdapter,
+        tmp_path: Path,
+    ) -> None:
         """Test ADO → OpenSpec import (ADO work item → change proposal)."""
         from unittest.mock import MagicMock