Transitions on destroyed swiper

[JoniVanderheijden]

I'm pretty new to this code base, so feel free to ignore this while I dig a bit deeper.
I'm investigating an error where I'm getting a ton of errors due to this piece of code being run on a destroyed Swiper which doesn't have any params anymore:

swiper/src/core/transition/setTransition.js

Line 4 in e641fd2

if (!swiper.params.cssMode) {

That happens often in our React app because we're unmounting and mounting the Swiper when switching pages.

I could get off easy by just contributing a !swiper.disabled there but it doesn't feel like the right spot to do that.

I'm likely better off fixing the check that triggers the transition on a destroyed Swiper instance. We likely don't want any more transitions on a destroyed instance anyway.
I imagine I need to actually check here if the instance is destroyed:

swiper/src/modules/thumbs/thumbs.js

Line 212 in e641fd2

if (!thumbsSwiper) return;

Does that reasoning make sense?

[JoniVanderheijden]

I'm testing out this patch-package file and it seems good:
/patches/swiper+8.0.7.patch

diff --git a/node_modules/swiper/modules/thumbs/thumbs.js b/node_modules/swiper/modules/thumbs/thumbs.js
index e37207e..5de5044 100644
--- a/node_modules/swiper/modules/thumbs/thumbs.js
+++ b/node_modules/swiper/modules/thumbs/thumbs.js
@@ -89,7 +89,7 @@ export default function Thumb(_ref) {
 
   function update(initial) {
     const thumbsSwiper = swiper.thumbs.swiper;
-    if (!thumbsSwiper) return;
+    if (!thumbsSwiper || thumbsSwiper.destroyed) return;
     const slidesPerView = thumbsSwiper.params.slidesPerView === 'auto' ? thumbsSwiper.slidesPerViewDynamic() : thumbsSwiper.params.slidesPerView;
     const autoScrollOffset = swiper.params.thumbs.autoScrollOffset;
     const useOffset = autoScrollOffset && !thumbsSwiper.params.loop;
@@ -187,7 +187,7 @@ export default function Thumb(_ref) {
   });
   on('setTransition', (_s, duration) => {
     const thumbsSwiper = swiper.thumbs.swiper;
-    if (!thumbsSwiper) return;
+    if (!thumbsSwiper || thumbsSwiper.destroyed) return;
     thumbsSwiper.setTransition(duration);
   });
   on('beforeDestroy', () => {

[JoniVanderheijden]

I created a PR to fix it permanently: #5582

But after digging deeper it seems like a perfect storm of rendering method, integration method and the tools used. Pretty edge case.