refactor: fix linting

Author: Lockwarr

x/contractmanager/keeper/failure.go

@@ -44,7 +44,10 @@ func (k Keeper) AddContractFailure(ctx context.Context, address string, sudoPayl
 func (k Keeper) GetNextFailureIDKey(ctx context.Context, address string) uint64 {
 	store := prefix.NewStore(runtime.KVStoreAdapter(k.storeService.OpenKVStore(ctx)), types.GetFailureKeyPrefix(address))
 	iterator := storetypes.KVStoreReversePrefixIterator(store, []byte{})
-	defer iterator.Close()
+	err := iterator.Close()
+	if err != nil {
+		k.Logger(ctx).Error(err.Error())
+	}
 
 	if iterator.Valid() {
 		var val types.Failure
@@ -60,7 +63,10 @@ func (k Keeper) GetNextFailureIDKey(ctx context.Context, address string) uint64
 func (k Keeper) GetAllFailures(ctx context.Context) (list []types.Failure) {
 	store := prefix.NewStore(runtime.KVStoreAdapter(k.storeService.OpenKVStore(ctx)), types.ContractFailuresKey)
 	iterator := storetypes.KVStorePrefixIterator(store, []byte{})
-	defer iterator.Close()
+	err := iterator.Close()
+	if err != nil {
+		k.Logger(ctx).Error(err.Error())
+	}
 
 	for ; iterator.Valid(); iterator.Next() {
 		var val types.Failure

x/feerefunder/keeper/keeper.go

@@ -197,7 +197,10 @@ func (k Keeper) GetAllFeeInfos(ctx sdk.Context) []types.FeeInfo {
 	infos := make([]types.FeeInfo, 0)
 
 	iterator := storetypes.KVStorePrefixIterator(store, []byte{})
-	defer iterator.Close()
+	err := iterator.Close()
+	if err != nil {
+		k.Logger(ctx).Error(err.Error())
+	}
 
 	for ; iterator.Valid(); iterator.Next() {
 		var info types.FeeInfo

x/tax/keeper/params.go

@@ -38,42 +38,27 @@ func (k Keeper) SetParams(ctx context.Context, params types.Params) error {
 
 // FeeRate returns the fee rate.
 func (k Keeper) FeeRate(ctx context.Context) int32 {
-	store := k.storeService.OpenKVStore(ctx)
-
-	b, err := store.Get(types.ParamsKey)
+	p, err := k.GetParams(ctx)
 	if err != nil {
 		return 0
 	}
-
-	var p types.Params
-	k.cdc.Unmarshal(b, &p)
 	return p.FeeRate
 }
 
 // TreasuryAddress returns the contract address.
 func (k Keeper) TreasuryAddress(ctx context.Context) string {
-	store := k.storeService.OpenKVStore(ctx)
-
-	b, err := store.Get(types.ParamsKey)
+	p, err := k.GetParams(ctx)
 	if err != nil {
 		return ""
 	}
-
-	var p types.Params
-	k.cdc.Unmarshal(b, &p)
 	return p.TreasuryAddress
 }
 
 // BaseDenom returns the base denom.
 func (k Keeper) BaseDenom(ctx context.Context) string {
-	store := k.storeService.OpenKVStore(ctx)
-
-	b, err := store.Get(types.ParamsKey)
+	p, err := k.GetParams(ctx)
 	if err != nil {
 		return ""
 	}
-
-	var p types.Params
-	k.cdc.Unmarshal(b, &p)
 	return p.BaseDenom
 }