fix: extra validation on tax params

Lockwarr · Lockwarr · commit b5e9c4e48bb9 · 2025-01-13T16:08:14.000+02:00
diff --git a/x/tax/typesv2/params.go b/x/tax/typesv2/params.go
@@ -145,8 +145,12 @@ func validateFeeParams(v interface{}) error {
 	}
 
 	for _, feeParam := range feeParams {
+		err := validateContractAddress(feeParam.ProfitAddress)
+		if err != nil {
+			return errorsmod.Wrap(ErrInvalidFeeParam, err.Error())
+		}
 		if feeParam.ProfitAddress == "" || strings.TrimSpace(feeParam.ProfitAddress) == "" {
-			return ErrInvalidFeeParam
+			return errorsmod.Wrap(ErrInvalidFeeParam, "profit address cannot be blank")
 		}
 		for _, denomPrice := range feeParam.AcceptedDenomsMinPrices {
 			if denomPrice.Denom == "" || strings.TrimSpace(denomPrice.Denom) == "" ||

Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,12 @@ func validateFeeParams(v interface{}) error {`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`for _, feeParam := range feeParams {`
	`148`	`+ err := validateContractAddress(feeParam.ProfitAddress)`
	`149`	`+ if err != nil {`
	`150`	`+ return errorsmod.Wrap(ErrInvalidFeeParam, err.Error())`
	`151`	`+ }`
`148`	`152`	`if feeParam.ProfitAddress == "" \|\| strings.TrimSpace(feeParam.ProfitAddress) == "" {`
`149`		`- return ErrInvalidFeeParam`
	`153`	`+ return errorsmod.Wrap(ErrInvalidFeeParam, "profit address cannot be blank")`
`150`	`154`	`}`
`151`	`155`	`for _, denomPrice := range feeParam.AcceptedDenomsMinPrices {`
`152`	`156`	`if denomPrice.Denom == "" \|\| strings.TrimSpace(denomPrice.Denom) == "" \|\|`