fix: Load correct icon on Flatpak #3582
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a desktop with KDE Plasma, it was being shown a generic Wayland icon for GPT4All (Flatpak) because it couldn't match the running window to the desktop entry. This was due to the missing StartupWMClass field in the .desktop file. By adding "StartupWMClass=io.gpt4all.chat" the window-class mismatch was fixed and allowed KDE to display the correct icon. Signed-off-by: Diogo Caveiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
On a desktop with KDE Plasma, it was being shown a generic Wayland icon for GPT4All (Flatpak) because it couldn't match the running window to the desktop entry. This was due to the missing StartupWMClass field in the .desktop file.
By adding "StartupWMClass=io.gpt4all.chat" the window-class mismatch was fixed and allowed KDE to display the correct icon.
Issue ticket number and link
No issue
Checklist before requesting a review
Demo
Before the fix
After the fix
Steps to Reproduce