Do not duplicate already duplicated string

Mladen Turk · Felipe Zimmerle · commit e02b4a10b327 · 2018-12-17T10:03:40.000-03:00
diff --git a/modsec-sdbm-util.c b/modsec-sdbm-util.c
@@ -356,13 +356,13 @@ static int dump_database(apr_pool_t *pool, apr_sdbm_t *db, int action, char *new
     return fret;
 }
 
-int remove_key (apr_pool_t *pool, apr_sdbm_t *db, const char *key_str)
+int remove_key (apr_pool_t *pool, apr_sdbm_t *db, char *key_str)
 {
     apr_sdbm_datum_t key;
 
     v("Deleting key: %s\n", key_str);
 
-    key.dptr = (char *)strdup(key_str);
+    key.dptr = key_str;
     key.dsize = strlen(key_str)+1;
 
     return remove_datum_t(pool, db, &key);

Original file line number	Diff line number	Diff line change
`@@ -356,13 +356,13 @@ static int dump_database(apr_pool_t pool, apr_sdbm_t db, int action, char *new`
`356`	`356`	`return fret;`
`357`	`357`	`}`
`358`	`358`
`359`		`-int remove_key (apr_pool_t pool, apr_sdbm_t db, const char *key_str)`
	`359`	`+int remove_key (apr_pool_t pool, apr_sdbm_t db, char *key_str)`
`360`	`360`	`{`
`361`	`361`	`apr_sdbm_datum_t key;`
`362`	`362`
`363`	`363`	`v("Deleting key: %s\n", key_str);`
`364`	`364`
`365`		`- key.dptr = (char *)strdup(key_str);`
	`365`	`+ key.dptr = key_str;`
`366`	`366`	`key.dsize = strlen(key_str)+1;`
`367`	`367`
`368`	`368`	`return remove_datum_t(pool, db, &key);`