Skip to content

Commit 35ff826

Browse files
committed
Replace underscore with dash in unit name
Replace CMake option prefix to STRING_VIEW_LITE_OPT_ (was: STRINGVIEW_LITE_OPT_)
1 parent 7ceb7fb commit 35ff826

14 files changed

+32
-32
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,6 @@ script:
156156
- export CXX=${COMPILER}
157157
- JOBS=2 # Travis machines have 2 cores.
158158
- mkdir build && cd build
159-
- cmake -G "Unix Makefiles" -DSTRINGVIEW_LITE_OPT_SELECT_NONSTD=ON -DSTRINGVIEW_LITE_OPT_BUILD_TESTS=ON -DSTRINGVIEW_LITE_OPT_BUILD_EXAMPLES=OFF ..
159+
- cmake -G "Unix Makefiles" -DSTRING_VIEW_LITE_OPT_SELECT_NONSTD=ON -DSTRING_VIEW_LITE_OPT_BUILD_TESTS=ON -DSTRING_VIEW_LITE_OPT_BUILD_EXAMPLES=OFF ..
160160
- cmake --build . -- -j${JOBS}
161161
- ctest --output-on-failure -j${JOBS}

CMakeLists.txt

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ project(
1818

1919
# Package information:
2020

21-
set( unit_name "string_view" )
21+
set( unit_name "string-view" )
2222
set( package_nspace "nonstd" )
2323
set( package_name "${unit_name}-lite" )
2424
set( package_version "${${PROJECT_NAME}_VERSION}" )
@@ -35,23 +35,23 @@ endif()
3535

3636
# If toplevel project, enable building and performing of tests, disable building of examples:
3737

38-
option( STRINGVIEW_LITE_OPT_BUILD_TESTS "Build and perform string-view-lite tests" ${string_view_IS_TOPLEVEL_PROJECT} )
39-
option( STRINGVIEW_LITE_OPT_BUILD_EXAMPLES "Build string-view-lite examples" OFF )
38+
option( STRING_VIEW_LITE_OPT_BUILD_TESTS "Build and perform string-view-lite tests" ${string_view_IS_TOPLEVEL_PROJECT} )
39+
option( STRING_VIEW_LITE_OPT_BUILD_EXAMPLES "Build string-view-lite examples" OFF )
4040

41-
option( STRINGVIEW_LITE_OPT_SELECT_STD "Select std::string_view" OFF )
42-
option( STRINGVIEW_LITE_OPT_SELECT_NONSTD "Select nonstd::string_view" OFF )
41+
option( STRING_VIEW_LITE_OPT_SELECT_STD "Select std::string_view" OFF )
42+
option( STRING_VIEW_LITE_OPT_SELECT_NONSTD "Select nonstd::string_view" OFF )
4343

44-
option( STRINGVIEW_LITE_OPT_CONV_STD_STRING_CLASS_METHODS "Provide conversion to/from std::string (class methods)" ON )
45-
option( STRINGVIEW_LITE_OPT_CONV_STD_STRING_FREE_FUNCTIONS "Provide conversion to/from std::string (free functions)" ON )
44+
option( STRING_VIEW_LITE_OPT_CONV_STD_STRING_CLASS_METHODS "Provide conversion to/from std::string (class methods)" ON )
45+
option( STRING_VIEW_LITE_OPT_CONV_STD_STRING_FREE_FUNCTIONS "Provide conversion to/from std::string (free functions)" ON )
4646

4747
# If requested, build and perform tests, build examples:
4848

49-
if ( STRINGVIEW_LITE_OPT_BUILD_TESTS )
49+
if ( STRING_VIEW_LITE_OPT_BUILD_TESTS )
5050
enable_testing()
5151
add_subdirectory( test )
5252
endif()
5353

54-
if ( STRINGVIEW_LITE_OPT_BUILD_EXAMPLES )
54+
if ( STRING_VIEW_LITE_OPT_BUILD_EXAMPLES )
5555
enable_testing()
5656
add_subdirectory( example )
5757
endif()

appveyor.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ build:
2020
environment:
2121
matrix:
2222
- generator: "Visual Studio 15 2017"
23-
select_sv: -DSTRINGVIEW_LITE_OPT_SELECT_STD=ON
23+
select_sv: -DSTRING_VIEW_LITE_OPT_SELECT_STD=ON
2424
- generator: "Visual Studio 15 2017"
25-
select_sv: -DSTRINGVIEW_LITE_OPT_SELECT_NONSTD=ON
25+
select_sv: -DSTRING_VIEW_LITE_OPT_SELECT_NONSTD=ON
2626
- generator: "Visual Studio 14 2015"
2727
- generator: "Visual Studio 12 2013"
2828
- generator: "Visual Studio 11 2012"
@@ -49,7 +49,7 @@ matrix:
4949

5050
before_build:
5151
- mkdir build && cd build
52-
- cmake -A %platform% -G "%generator%" "%select_sv%" -DSTRINGVIEW_LITE_OPT_BUILD_TESTS=ON -DSTRINGVIEW_LITE_OPT_BUILD_EXAMPLES=OFF ..
52+
- cmake -A %platform% -G "%generator%" "%select_sv%" -DSTRING_VIEW_LITE_OPT_BUILD_TESTS=ON -DSTRING_VIEW_LITE_OPT_BUILD_EXAMPLES=OFF ..
5353

5454
build_script:
5555
- cmake --build . --config %configuration%
File renamed without changes.

conanfile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ def build(self):
1818
def package(self):
1919
"""Run CMake install"""
2020
cmake = CMake(self)
21-
cmake.definitions["STRINGVIEW_LITE_OPT_BUILD_TESTS"] = "OFF"
22-
cmake.definitions["STRINGVIEW_LITE_OPT_BUILD_EXAMPLES"] = "OFF"
21+
cmake.definitions["STRING_VIEW_LITE_OPT_BUILD_TESTS"] = "OFF"
22+
cmake.definitions["STRING_VIEW_LITE_OPT_BUILD_EXAMPLES"] = "OFF"
2323
cmake.configure()
2424
cmake.install()
2525

project/CodeBlocks/string-view-lite.cbp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
<Unit filename="../../LICENSE.txt" />
1919
<Unit filename="../../README.md" />
2020
<Unit filename="../../appveyor.yml" />
21-
<Unit filename="../../cmake/string_view-lite-config-version.cmake.in" />
22-
<Unit filename="../../cmake/string_view-lite-config.cmake.in" />
21+
<Unit filename="../../cmake/string-view-lite-config-version.cmake.in" />
22+
<Unit filename="../../cmake/string-view-lite-config.cmake.in" />
2323
<Unit filename="../../conanfile.py" />
2424
<Unit filename="../../example/01-basic.cpp" />
2525
<Unit filename="../../example/02-no-exceptions.cpp" />
@@ -30,9 +30,9 @@
3030
<Unit filename="../../script/upload-conan.py" />
3131
<Unit filename="../../test/CMakeLists.txt" />
3232
<Unit filename="../../test/lest_cpp03.hpp" />
33-
<Unit filename="../../test/string_view-main.t.cpp" />
34-
<Unit filename="../../test/string_view-main.t.hpp" />
35-
<Unit filename="../../test/string_view.t.cpp" />
33+
<Unit filename="../../test/string-view-main.t.cpp" />
34+
<Unit filename="../../test/string-view-main.t.hpp" />
35+
<Unit filename="../../test/string-view.t.cpp" />
3636
<Unit filename="../../test/t-std.bat" />
3737
<Unit filename="../../test/t.bat" />
3838
<Unit filename="../../test/tc.bat" />

test/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ endif()
1111

1212
project( test LANGUAGES CXX )
1313

14-
set( unit_name "string_view" )
14+
set( unit_name "string-view" )
1515
set( PACKAGE ${unit_name}-lite )
1616
set( PROGRAM ${unit_name}-lite )
1717
set( SOURCES ${unit_name}-main.t.cpp ${unit_name}.t.cpp )
18-
set( HEADER "nonstd/${unit_name}.hpp" )
18+
set( HEADER "nonstd/string_view.hpp" )
1919

2020
message( STATUS "Subproject '${PROJECT_NAME}', programs '${PROGRAM}-*'")
2121

@@ -29,8 +29,8 @@ macro( opt option_text var )
2929
endif()
3030
endmacro()
3131

32-
opt( STRINGVIEW_LITE_OPT_CONV_STD_STRING_CLASS_METHODS nssv_CONFIG_CONVERSION_STD_STRING_CLASS_METHODS )
33-
opt( STRINGVIEW_LITE_OPT_CONV_STD_STRING_FREE_FUNCTIONS nssv_CONFIG_CONVERSION_STD_STRING_FREE_FUNCTIONS )
32+
opt( STRING_VIEW_LITE_OPT_CONV_STD_STRING_CLASS_METHODS nssv_CONFIG_CONVERSION_STD_STRING_CLASS_METHODS )
33+
opt( STRING_VIEW_LITE_OPT_CONV_STD_STRING_FREE_FUNCTIONS nssv_CONFIG_CONVERSION_STD_STRING_FREE_FUNCTIONS )
3434

3535
set( DEFCMN -Dnssv_STRING_VIEW_HEADER=\"${HEADER}\"
3636
-Dnssv_CONFIG_CONVERSION_STD_STRING_CLASS_METHODS=${nssv_CONFIG_CONVERSION_STD_STRING_CLASS_METHODS}
@@ -196,9 +196,9 @@ endif()
196196
if( HAS_CPP17_FLAG )
197197
set( WHICH nssv_STRING_VIEW_DEFAULT )
198198

199-
if( STRINGVIEW_LITE_OPT_SELECT_STD )
199+
if( STRING_VIEW_LITE_OPT_SELECT_STD )
200200
set( WHICH nssv_STRING_VIEW_STD )
201-
elseif( STRINGVIEW_LITE_OPT_SELECT_NONSTD )
201+
elseif( STRING_VIEW_LITE_OPT_SELECT_NONSTD )
202202
set( WHICH nssv_STRING_VIEW_NONSTD )
203203
endif()
204204

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// Distributed under the Boost Software License, Version 1.0.
66
// (See accompanying file LICENSE.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
77

8-
#include "string_view-main.t.hpp"
8+
#include "string-view-main.t.hpp"
99

1010
#define nssv_PRESENT( x ) \
1111
std::cout << #x << ": " << x << "\n"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
// Limit C++ Core Guidelines checking to GSL Lite:
2929

30-
#if defined(_MSC_VER) && _MSC_VER >= 1910
30+
#if nssv_COMPILER_MSVC_VER >= 1910
3131
# include <CppCoreCheck/Warnings.h>
3232
# pragma warning(disable: ALL_CPPCORECHECK_WARNINGS)
3333
#endif

0 commit comments

Comments
 (0)