system store - load from core - two steps publish - PR notes 2

Signed-off-by: Amit Prinz Setter <[email protected]>

Author: alphaprinz

config.js

@@ -250,6 +250,8 @@ config.INTERNAL_STORAGE_POOL_NAME = 'system-internal-storage-pool';
 config.ALLOW_BUCKET_CREATE_ON_INTERNAL = true;
 config.BUCKET_AUTOCONF_TIER2_ENABLED = false;
 config.SYSTEM_STORE_LOAD_CONCURRENCY = parseInt(process.env.SYSTEM_STORE_LOAD_CONCURRENCY, 10) || 5;
+// SYSTEM_STORE_SOURCE determines the preffered source for loading system_store data
+// This can be either "DB" to load from the DB or "CORE" to load from the system_server in noobaa-core
 config.SYSTEM_STORE_SOURCE = process.env.SYSTEM_STORE_SOURCE || "DB";
 //////////////////////////
 // MD AGGREGATOR CONFIG //

src/server/system_services/system_store.js

@@ -504,6 +504,9 @@ class SystemStore extends EventEmitter {
 
     //return the latest copy of in-memory data
     async recent_db_data() {
+        if (this.source === SOURCE.CORE) {
+                throw new RpcError('BAD_REQUEST', 'recent_db_data is not available for CORE source');
+        }
         return this._load_serial.surround(async () => this.old_db_data);
     }
 

src/test/integration_tests/db/test_system_store.js

@@ -148,7 +148,7 @@ mocha.describe('system_store', function() {
         const from_db = await system_store.load();
         const from_core = await system_store_from_core.load(undefined, 'ENDPOINT');
 
-        assert.deepStrictEqual(from_db, from_core);
+        assert.deepStrictEqual(from_db.data, from_core.data);
 
     });