read_object_stream method

Author: naveenpaul1

src/sdk/namespace_s3.js

@@ -35,6 +35,9 @@ class NamespaceS3 {
         this.access_key = s3_params.accessKeyId;
         this.endpoint = s3_params.endpoint;
         this.s3 = noobaa_s3_client.get_s3_client_v3_params(s3_params);
+        if (!bucket) {
+            throw new Error('NamespaceS3: bucket is required');
+        }
         this.bucket = String(bucket);
         this.access_mode = s3_params.access_mode;
         this.stats = stats;
@@ -207,8 +210,10 @@ class NamespaceS3 {
                     await this.s3.getObject(request) :
                     await this.s3.headObject(request);
             } catch (err) {
-                // catch invalid range error for objects of size 0 and trying head object instead
-                if (err.code !== 'InvalidRange') {
+                // catch invalid range error for objects of size 0 and try head object instead
+                const httpCode = err?.$metadata?.httpStatusCode;
+                const isInvalidRange = err?.name === 'InvalidRange' || httpCode === 416;
+                if (!isInvalidRange) {
                     throw err;
                 }
                 res = await this.s3.headObject({ ...request, Range: undefined });
@@ -256,7 +261,8 @@ class NamespaceS3 {
                         this.bucket,
                         inspect(_.omit(params, 'object_md.ns')),
                     );
-            if (obj_out.$metadata.httpStatusCode >= 300) return; // will be handled by error event
+            // In v3, non-2xx typically throws; keep this guard harmless.
+            if (obj_out.$metadata.httpStatusCode >= 300) throw new Error(`S3 getObject failed with status ${obj_out.$metadata.httpStatusCode}`);
             let count = 1;
             // on s3 read_object_md might not return x-amz-tagging-count header, so we get it here
             //params.tag_count = headers['x-amz-tagging-count'];
@@ -270,12 +276,13 @@ class NamespaceS3 {
                 // clear count for next updates
                 count = 0;
             });
-            const read_stream = /** @type {import('stream').Readable} **/ obj_out.Body.transformToWebStream();
-            await stream_utils.pipeline([read_stream, count_stream], true);
-            return count_stream;
+            const read_stream = /** @type {import('stream').Readable} */ (obj_out.Body);
+            // Return a live stream to be piped by the caller (endpoint)
+            return read_stream.pipe(count_stream);
         } catch (err) {
             this._translate_error_code(params, err);
             dbg.warn('NamespaceS3.read_object_stream:', inspect(err));
+            throw err;
         }
     }
 
@@ -350,16 +357,15 @@ class NamespaceS3 {
             }
         }
         dbg.log0('NamespaceS3.upload_object:', this.bucket, inspect(params), 'res', inspect(res));
-        const etag = s3_utils.parse_etag(res.ETag);
-        /** @type {import("@aws-sdk/client-s3").GetObjectAttributesRequest} */
+        const etag = s3_utils.parse_etag(res.ETag || res.CopyObjectResult?.ETag);
+        /** @type {import("@aws-sdk/client-s3").HeadObjectRequest} */
         const request = {
             Bucket: this.bucket,
             Key: params.key,
             VersionId: params.version_id,
-            ObjectAttributes: params.attributes,
         };
         const res_head = await this.s3.headObject(request);
-        const last_modified_time = await s3_utils.get_http_response_date(res_head, this.s3, this.bucket, params.key);
+        const last_modified_time = await s3_utils.get_http_response_date(res_head);
         return { etag, version_id: res.VersionId, last_modified_time };
     }
 
@@ -477,7 +483,7 @@ class NamespaceS3 {
             Key: params.key,
             UploadId: params.obj_id,
             MaxParts: params.max,
-            PartNumberMarker: params.num_marker.toString(),
+            PartNumberMarker: params.num_marker?.toString(),
         };
         const res = await this.s3.listParts(req);
         dbg.log0('NamespaceS3.list_multiparts:', this.bucket, inspect(params), 'res', inspect(res));

src/sdk/object_sdk.js

@@ -470,10 +470,7 @@ class ObjectSDK {
                     region: config.DEFAULT_REGION, // SDKv3 needs region
                     forcePathStyle: true,
                     requestHandler: noobaa_s3_client.get_requestHandler_with_suitable_agent(r.endpoint),
-                    requestStreamBufferSize: config.IO_STREAM_SPLIT_SIZE,
-                    computeChecksums: false, // disabled by default for performance
                     access_mode: r.access_mode,
-                    //signatureVersion: cloud_utils.get_s3_endpoint_signature_ver(r.endpoint, r.auth_method)
                 },
                 bucket: r.target_bucket,
                 stats: this.stats,