#1673 Warning on adding associated product with attributes as product attribute value

Author: RomanovM

src/Presentation/Nop.Web/Administration/Content/styles.css

@@ -35,8 +35,8 @@ ul, ol {
 .field-validation-valid.warning {
     color: #fff;
     background-color: #f39c12;
-    margin-top: 5px;
-    display: inline-block;
+    margin: 5px 0;
+    display: block;
     padding: 5px;
     border-radius: 3px;
     border-left: 5px solid #c87f0a;

src/Presentation/Nop.Web/Administration/Content/styles.rtl.css

@@ -35,8 +35,8 @@ ul, ol {
 .field-validation-valid.warning {
     color: #fff;
     background-color: #f39c12;
-    margin-top: 5px;
-    display: inline-block;
+    margin: 5px 0;
+    display: block;
     padding: 5px;
     border-radius: 3px;
     border-right: 5px solid #c87f0a;

src/Presentation/Nop.Web/Administration/Controllers/ProductController.cs

@@ -4344,7 +4344,6 @@ public ActionResult AssociateProductToAttributeValuePopup(string productIdInput,
             if (_workContext.CurrentVendor != null && associatedProduct.VendorId != _workContext.CurrentVendor.Id)
                 return Content("This is not your product");
 
-            //a vendor should have access only to his products
             model.IsLoggedInAsVendor = _workContext.CurrentVendor != null;
             ViewBag.RefreshPage = true;
             ViewBag.productIdInput = productIdInput;
@@ -4354,6 +4353,21 @@ public ActionResult AssociateProductToAttributeValuePopup(string productIdInput,
             return View(model);
         }
 
+        //action displaying notification (warning) to a store owner that associated product has attributes
+        [ValidateInput(false)]
+        public ActionResult AssociatedProductHasAttributes(int productId)
+        {
+            var associatedProduct = _productService.GetProductById(productId);
+            if (associatedProduct != null && associatedProduct.ProductAttributeMappings.Any())
+            {
+                if (associatedProduct.ProductAttributeMappings.Any(attribute => attribute.IsRequired))
+                    return Json(new { Result = _localizationService.GetResource("Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.HasRequiredAttributes") }, JsonRequestBehavior.AllowGet);
+
+                return Json(new { Result = _localizationService.GetResource("Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.HasAttributes") }, JsonRequestBehavior.AllowGet);
+            }
+
+            return Json(new { Result = string.Empty }, JsonRequestBehavior.AllowGet);
+        }
 
         #endregion
 

src/Presentation/Nop.Web/Administration/Views/Product/AssociateProductToAttributeValuePopup.cshtml

@@ -13,7 +13,7 @@
 {
     <script type="text/javascript">
         try {
-            window.opener.document.getElementById('@(ViewBag.productIdInput)').value = '@(ViewBag.productId)';
+            window.opener.$('#@(ViewBag.productIdInput)').val('@(ViewBag.productId)').trigger('change');
             window.opener.document.getElementById('@(ViewBag.productNameInput)').innerHTML = '@(ViewBag.productName)';
         }
         catch (e){}

src/Presentation/Nop.Web/Administration/Views/Product/_CreateOrUpdateProductAttributeValue.cshtml

@@ -84,6 +84,17 @@
                             <button type="submit" onclick="javascript:OpenWindow('@(Url.Action("AssociateProductToAttributeValuePopup", "Product", new {productIdInput = Html.FieldIdFor(model => model.AssociatedProductId), productNameInput = "associate-product-name"}))', 800, 850, true); return false;" class="btn btn-primary">
                                 @T("Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.AddNew")
                             </button>
+                            <script type="text/javascript">
+                                $(document).ready(function () {
+                                    if (@Model.AssociatedProductId > 0) {
+                                        warningValidation('@Url.Action("AssociatedProductHasAttributes", "Product")', '@Html.FieldNameFor(model => model.AssociatedProductId)', { productId: '@Model.AssociatedProductId' });
+                                    }
+                                    
+                                    $('#@Html.FieldIdFor(model => model.AssociatedProductId)').on('change', function () {
+                                        warningValidation('@Url.Action("AssociatedProductHasAttributes", "Product")', '@Html.FieldNameFor(model => model.AssociatedProductId)', { productId: $(this).val() });
+                                    });
+                                });
+                            </script>
                         </div>
                     </div>
                     <div class="form-group" id="group-customer-enters-qty">

src/Presentation/Nop.Web/App_Data/Localization/defaultResources.nopres.xml

@@ -3465,6 +3465,12 @@
   <LocaleResource Name="Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.Choose">
     <Value>Choose an associated product</Value>
   </LocaleResource>
+  <LocaleResource Name="Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.HasAttributes">
+    <Value>The associated product has attributes, keep in mind that customers can not select them in the product details page.</Value>
+  </LocaleResource>
+  <LocaleResource Name="Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.HasRequiredAttributes">
+    <Value>The associated product has required product attributes, so customers won't be able to choose this product attribute value.</Value>
+  </LocaleResource>
   <LocaleResource Name="Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.Hint">
     <Value>Associated product.</Value>
   </LocaleResource>

upgradescripts/3.80-the next version/upgrade.sql

@@ -1106,6 +1106,12 @@ set @resources='
   <LocaleResource Name="Admin.ContentManagement.News.Comments.Fields.StoreName">
     <Value>Store name</Value>
   </LocaleResource>
+  <LocaleResource Name="Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.HasAttributes">
+    <Value>The associated product has attributes, keep in mind that customers can not select them in the product details page.</Value>
+  </LocaleResource>
+  <LocaleResource Name="Admin.Catalog.Products.ProductAttributes.Attributes.Values.Fields.AssociatedProduct.HasRequiredAttributes">
+    <Value>The associated product has required product attributes, so customers won''t be able to choose this product attribute value.</Value>
+  </LocaleResource>
 </Language>
 '