Skip to content

Commit d9255c4

Browse files
committed
Merge branch 'issue-7609-Use-curly-braces' into develop
# Conflicts: # src/Libraries/Nop.Data/Migrations/UpgradeTo470/AddIndexesMigration.cs
2 parents 33581c1 + ad07e85 commit d9255c4

File tree

222 files changed

+742
-974
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

222 files changed

+742
-974
lines changed

src/Libraries/Nop.Core/Caching/DistributedCacheLocker.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,12 @@ public virtual async Task CancelTaskAsync(string key, TimeSpan expirationTime)
127127
var status = await _distributedCache.GetStringAsync(key);
128128
if (!string.IsNullOrEmpty(status) &&
129129
JsonConvert.DeserializeObject<TaskStatus>(status) != TaskStatus.Canceled)
130+
{
130131
await _distributedCache.SetStringAsync(
131132
key,
132133
JsonConvert.SerializeObject(TaskStatus.Canceled),
133134
new DistributedCacheEntryOptions { AbsoluteExpirationRelativeToNow = expirationTime });
135+
}
134136
}
135137

136138
/// <summary>

src/Libraries/Nop.Core/Caching/MemoryCacheManager.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,10 +246,12 @@ public virtual async Task<object> GetAsync(CacheKey key)
246246
public virtual Task SetAsync<T>(CacheKey key, T data)
247247
{
248248
if (data != null && (key?.CacheTime ?? 0) > 0)
249+
{
249250
_memoryCache.Set(
250251
key.Key,
251252
new Lazy<Task<T>>(() => Task.FromResult(data), true),
252253
PrepareEntryOptions(key));
254+
}
253255

254256
return Task.CompletedTask;
255257
}

src/Libraries/Nop.Core/ComponentModel/ReaderWriteLockDisposable.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ protected virtual void Dispose(bool disposing)
5656
return;
5757

5858
if (disposing)
59+
{
5960
switch (_readerWriteLockType)
6061
{
6162
case ReaderWriteLockType.Read:
@@ -68,6 +69,7 @@ protected virtual void Dispose(bool disposing)
6869
_rwLock.ExitUpgradeableReadLock();
6970
break;
7071
}
72+
}
7173

7274
_disposed = true;
7375
}

src/Libraries/Nop.Core/Configuration/AppSettings.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,8 @@ public virtual TConfig Get<TConfig>() where TConfig : class, IConfig
4747
/// <param name="configurations">Configurations to update</param>
4848
public virtual void Update(IList<IConfig> configurations)
4949
{
50-
foreach (var config in configurations)
51-
{
50+
foreach (var config in configurations)
5251
_configurations[config.GetType()] = config;
53-
}
5452
}
5553

5654
#endregion

src/Libraries/Nop.Core/Configuration/AppSettingsHelper.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ public static AppSettings SaveAppSettings(IList<IConfig> configurations, INopFil
4242
fileProvider.CreateFile(filePath);
4343

4444
//get raw configuration parameters
45-
var configuration = JsonConvert.DeserializeObject<AppSettings>(fileProvider.ReadAllText(filePath, Encoding.UTF8))
46-
?.Configuration
47-
?? new();
45+
var configuration = JsonConvert
46+
.DeserializeObject<AppSettings>(fileProvider.ReadAllText(filePath, Encoding.UTF8))
47+
?.Configuration
48+
?? new();
49+
4850
foreach (var config in configurations)
49-
{
5051
configuration[config.Name] = JToken.FromObject(config);
51-
}
5252

5353
//sort configurations for display by order (e.g. data configuration with 0 will be the first)
5454
appSettings.Configuration = configuration

src/Libraries/Nop.Core/Domain/Messages/AdditionalTokensAddedEvent.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,8 @@ public AdditionalTokensAddedEvent()
1616
/// <param name="additionalTokens">Additional tokens</param>
1717
public virtual void AddTokens(params string[] additionalTokens)
1818
{
19-
foreach (var additionalToken in additionalTokens)
20-
{
19+
foreach (var additionalToken in additionalTokens)
2120
AdditionalTokens.Add(additionalToken);
22-
}
2321
}
2422

2523
/// <summary>

src/Libraries/Nop.Core/Domain/Shipping/ShippingOptionListTypeConverter.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@ public partial class ShippingOptionListTypeConverter : TypeConverter
2020
/// <returns>Result</returns>
2121
public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
2222
{
23-
if (sourceType == typeof(string))
24-
{
23+
if (sourceType == typeof(string))
2524
return true;
26-
}
2725

2826
return base.CanConvertFrom(context, sourceType);
2927
}

src/Libraries/Nop.Core/Domain/Shipping/ShippingOptionTypeConverter.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,8 @@ public partial class ShippingOptionTypeConverter : TypeConverter
2020
/// <returns>Result</returns>
2121
public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
2222
{
23-
if (sourceType == typeof(string))
24-
{
23+
if (sourceType == typeof(string))
2524
return true;
26-
}
2725

2826
return base.CanConvertFrom(context, sourceType);
2927
}

src/Libraries/Nop.Core/Infrastructure/EngineContext.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,8 @@ public static IEngine Current
4040
{
4141
get
4242
{
43-
if (Singleton<IEngine>.Instance == null)
44-
{
43+
if (Singleton<IEngine>.Instance == null)
4544
Create();
46-
}
4745

4846
return Singleton<IEngine>.Instance;
4947
}

src/Libraries/Nop.Core/Infrastructure/NopEngine.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ public virtual object ResolveUnregistered(Type type)
197197
{
198198
Exception innerException = null;
199199
foreach (var constructor in type.GetConstructors())
200+
{
200201
try
201202
{
202203
//try to resolve constructor parameters
@@ -213,6 +214,7 @@ public virtual object ResolveUnregistered(Type type)
213214
{
214215
innerException = ex;
215216
}
217+
}
216218

217219
throw new NopException("No constructor was found that had all the dependencies satisfied.", innerException);
218220
}

0 commit comments

Comments
 (0)