Skip to content

Commit f452da5

Browse files
authored
Merge pull request #2043 from manojkulkarni30/2022adminsectionlinks
#2022 Admin section links for help are opened in new tab.
2 parents def716e + c01b2ff commit f452da5

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

src/Presentation/Nop.Web.Framework/Menu/SiteMapNode.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,10 @@ public SiteMapNode()
5959
/// Gets or sets the item is visible
6060
/// </summary>
6161
public bool Visible { get; set; }
62+
63+
/// <summary>
64+
/// Gets or sets a value indicating whether to open url in new tab (window) or not
65+
/// </summary>
66+
public bool OpenUrlInNewTab { get; set; }
6267
}
6368
}

src/Presentation/Nop.Web.Framework/Menu/XmlSiteMap.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,14 @@ private static void PopulateNode(SiteMapNode siteMapNode, XmlNode xmlNode)
110110
{
111111
siteMapNode.Visible = true;
112112
}
113+
114+
// Open URL in new tab
115+
var openUrlInNewTabValue = GetStringValueFromAttribute(xmlNode, "OpenUrlInNewTab");
116+
bool booleanResult;
117+
if (!string.IsNullOrWhiteSpace(openUrlInNewTabValue) && bool.TryParse(openUrlInNewTabValue, out booleanResult))
118+
{
119+
siteMapNode.OpenUrlInNewTab = booleanResult;
120+
}
113121
}
114122

115123
private static string GetStringValueFromAttribute(XmlNode node, string attributeName)

src/Presentation/Nop.Web/Administration/Views/Shared/Menu.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
if (!String.IsNullOrEmpty(url))
2727
{
2828
<li @(isActive ? Html.Raw("class=\"active current-active-item\"") : null)>
29-
<a href="@url" class="menu-item-link">
29+
<a href="@url" class="menu-item-link"@(item.OpenUrlInNewTab ? Html.Raw(" target=\"_blank\"") : null)>
3030
@if (!String.IsNullOrEmpty(item.IconClass))
3131
{
3232
<text>

src/Presentation/Nop.Web/Administration/sitemap.config

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,9 @@
121121
</siteMapNode>
122122
</siteMapNode>
123123
<siteMapNode SystemName="Help" nopResource="Admin.Help" IconClass="fa-question-circle">
124-
<siteMapNode SystemName="Help topics" nopResource="Admin.Help.Topics" url="http://docs.nopcommerce.com/display/nc/nopCommerce+Documentation?utm_source=admin-panel&amp;utm_medium=menu&amp;utm_campaign=admin-panel" IconClass="fa-dot-circle-o"/>
125-
<siteMapNode SystemName="Community forums" nopResource="Admin.Help.Forums" url="http://www.nopcommerce.com/boards/?utm_source=admin-panel&amp;utm_medium=menu&amp;utm_campaign=admin-panel" IconClass="fa-dot-circle-o"/>
126-
<siteMapNode SystemName="Premium support services" nopResource="Admin.Help.SupportServices" url="http://www.nopcommerce.com/p/541/nopcommerce-premium-support-services.aspx?utm_source=admin-panel&amp;utm_medium=menu&amp;utm_campaign=admin-panel" IconClass="fa-dot-circle-o"/>
124+
<siteMapNode SystemName="Help topics" nopResource="Admin.Help.Topics" url="http://docs.nopcommerce.com/display/nc/nopCommerce+Documentation?utm_source=admin-panel&amp;utm_medium=menu&amp;utm_campaign=admin-panel" IconClass="fa-dot-circle-o" OpenUrlInNewTab="true"/>
125+
<siteMapNode SystemName="Community forums" nopResource="Admin.Help.Forums" url="http://www.nopcommerce.com/boards/?utm_source=admin-panel&amp;utm_medium=menu&amp;utm_campaign=admin-panel" IconClass="fa-dot-circle-o" OpenUrlInNewTab="true"/>
126+
<siteMapNode SystemName="Premium support services" nopResource="Admin.Help.SupportServices" url="http://www.nopcommerce.com/p/541/nopcommerce-premium-support-services.aspx?utm_source=admin-panel&amp;utm_medium=menu&amp;utm_campaign=admin-panel" IconClass="fa-dot-circle-o" OpenUrlInNewTab="true"/>
127127
</siteMapNode>
128128
<siteMapNode SystemName="Third party plugins" nopResource="Admin.Plugins" IconClass="fa-bars" />
129129
</siteMapNode>

0 commit comments

Comments
 (0)