From acc60e3cae7804b43cc0e400f700fa7cbb75fdb8 Mon Sep 17 00:00:00 2001 From: victor Date: Tue, 3 Mar 2026 11:02:04 +1100 Subject: [PATCH 1/5] Updated packages (for Symfony 8) --- composer.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/composer.json b/composer.json index 5151fd0..e32ee67 100644 --- a/composer.json +++ b/composer.json @@ -17,15 +17,15 @@ "psr/http-factory": "^1.0", "psr/http-factory-implementation": "^1.0", "symfony/deprecation-contracts": "^2.1|^3.0", - "symfony/options-resolver": "^4.4|^5.0|^6.0|^7.0" + "symfony/options-resolver": "^4.4|^5.0|^6.0|^7.0|^8" }, "require-dev": { "nyholm/psr7": "^1.8.1", "php-cs-fixer/shim": "^v3.64.0", "phpstan/phpstan": "^1.12.0", "phpstan/phpstan-phpunit": "^1.4.0", - "symfony/http-client": "^5.0|^6.2|^7.0", - "symfony/phpunit-bridge": "^5.3|^6.2|^7.0" + "symfony/http-client": "^5.0|^6.2|^7.0|^8", + "symfony/phpunit-bridge": "^5.3|^6.2|^7.0|^8" }, "autoload": { "psr-4": { "OneSignal\\": "src/" } From 99c0dbd69a95309dc08dfdf84131e709c512d2c6 Mon Sep 17 00:00:00 2001 From: victor Date: Tue, 3 Mar 2026 15:06:32 +1100 Subject: [PATCH 2/5] Updated variable visibility (shouldn't have any effect as the classes were already marked as final) --- src/Response/Segment/CreateSegmentResponse.php | 4 ++-- src/Response/Segment/DeleteSegmentResponse.php | 2 +- src/Response/Segment/ListSegmentsResponse.php | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Response/Segment/CreateSegmentResponse.php b/src/Response/Segment/CreateSegmentResponse.php index 0b56068..cf5b8b7 100644 --- a/src/Response/Segment/CreateSegmentResponse.php +++ b/src/Response/Segment/CreateSegmentResponse.php @@ -8,12 +8,12 @@ final class CreateSegmentResponse implements AbstractResponse { - protected bool $success; + private bool $success; /** * @var non-empty-string */ - protected string $id; + private string $id; /** * @param non-empty-string $id diff --git a/src/Response/Segment/DeleteSegmentResponse.php b/src/Response/Segment/DeleteSegmentResponse.php index d762a4b..bd1b3ab 100644 --- a/src/Response/Segment/DeleteSegmentResponse.php +++ b/src/Response/Segment/DeleteSegmentResponse.php @@ -8,7 +8,7 @@ final class DeleteSegmentResponse implements AbstractResponse { - protected bool $success; + private bool $success; public function __construct(bool $success) { diff --git a/src/Response/Segment/ListSegmentsResponse.php b/src/Response/Segment/ListSegmentsResponse.php index f036667..b4d2beb 100644 --- a/src/Response/Segment/ListSegmentsResponse.php +++ b/src/Response/Segment/ListSegmentsResponse.php @@ -12,22 +12,22 @@ final class ListSegmentsResponse implements AbstractResponse /** * @var non-negative-int */ - protected int $totalCount; + private int $totalCount; /** * @var int<0, 2147483648> */ - protected int $offset; + private int $offset; /** * @var int<0, 2147483648> */ - protected int $limit; + private int $limit; /** * @var list */ - protected array $segments; + private array $segments; /** * @param non-negative-int $totalCount From e0c19489f80af9e3f9d72ebea98fa1fa7e115f71 Mon Sep 17 00:00:00 2001 From: victor Date: Tue, 3 Mar 2026 17:17:34 +1100 Subject: [PATCH 3/5] Added conflict for CVE-2024-50342 --- composer.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/composer.json b/composer.json index e32ee67..11421ca 100644 --- a/composer.json +++ b/composer.json @@ -42,5 +42,8 @@ }, "config": { "sort-packages": true + }, + "conflict": { + "symfony/http-client": "<5.4.47|>=6,<6.4.15|>=7,<7.1.8" } } From b4d0f4155cc7257711c5e2fc608c1e8ce5b79553 Mon Sep 17 00:00:00 2001 From: victor Date: Tue, 3 Mar 2026 18:11:15 +1100 Subject: [PATCH 4/5] Updated to avoid certain pkgs with CVE --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 11421ca..d5d9f7a 100644 --- a/composer.json +++ b/composer.json @@ -24,7 +24,7 @@ "php-cs-fixer/shim": "^v3.64.0", "phpstan/phpstan": "^1.12.0", "phpstan/phpstan-phpunit": "^1.4.0", - "symfony/http-client": "^5.0|^6.2|^7.0|^8", + "symfony/http-client": "^5.4.47|^6.4.15|^7.1.8|^8.0", "symfony/phpunit-bridge": "^5.3|^6.2|^7.0|^8" }, "autoload": { From 86e5d401a071f078339434d7f191e786b05cf3ff Mon Sep 17 00:00:00 2001 From: victor Date: Tue, 3 Mar 2026 21:15:20 +1100 Subject: [PATCH 5/5] Updated with PHP8 --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7155427..c85db5c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -76,6 +76,8 @@ jobs: symfony-version: 6.4.* - php-version: 8.3 symfony-version: 7.0.* + - php-version: 8.5 + symfony-version: 8.0.* steps: - name: "Checkout" uses: actions/checkout@v4