Merge pull request #37 from norlab-ulaval/test-fix-slurm-job-dry-run-test-stability

Fix slurm dry run test stability

Author: RedLeader962

src/lib/core/execute/project_validate.slurm.bash

@@ -162,13 +162,14 @@ function dna::project_validate_slurm() {
 
   n2st::print_msg "Completed build in dry-run mode tests"
 
-  # ....Dry-run SLURM/Mamba jobs.....................................................................
+  # ....Dry-run SLURM/Mamba jobs on native aarch.....................................................
   n2st::print_formated_script_header "Dry-run slurm job" "${line_format}" "${line_style}"
   pushd "$(pwd)" >/dev/null || exit 1
 
+  # Execute slurm joc dry-run tests
   slurm_job_file_name=()
   for each_file_path in "${SUPER_PROJECT_ROOT:?err}"/"${slurm_script_job_path}"/slurm_job.*.bash ; do
-    each_file_name="$(basename $each_file_path)"
+    each_file_name="$(basename "${each_file_path}")"
     slurm_job_file_name+=("$each_file_name")
   done
 

tests/tests_dryrun_and_tests_scripts/test_project_validate.slurm.bash

@@ -12,11 +12,15 @@ function dna::test_teardown_callback() {
 }
 trap dna::test_teardown_callback EXIT
 
+# ====begin========================================================================================
+
+# Re-build slurm image (required on TC to prevent ownership error related to agent switching)
 cd "${DNA_MOCK_SUPER_PROJECT_ROOT:?err}" || exit 1
+bash "${DNA_LIB_EXEC_PATH:?err}"/build.all.bash --service-names project-slurm -- --no-cache
 
-# ====begin========================================================================================
 # Execute project validate slurm script
 # Note: the "--include-multiarch" flag affect only the dry-run config check, not the slurm job check
+cd "${DNA_MOCK_SUPER_PROJECT_ROOT:?err}" || exit 1
 bash "${DNA_LIB_EXEC_PATH:?err}"/project_validate.slurm.bash --include-multiarch "slurm_jobs"
 
 ## ....Teardown.....................................................................................