Skip to content

Commit 2c30d0f

Browse files
committed
Esql date casting tests (elastic#120420)
This adds appropriate ignore annotations for the date tests I added in elastic#119772 to not run the tests against very old versions. Should be a no-op for main, but fix some tests in 8.x BWC. Still, I'd rather keep the tests in sync, so I'm applying this to main first. It's not set for auto-backport because I'll need to add the unmutes to the backport.
1 parent 1a08818 commit 2c30d0f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/resources/date.csv-spec

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1453,6 +1453,7 @@ cnt:long
14531453
;
14541454

14551455
implicit casting strings to dates for IN operator
1456+
required_capability: string_literal_auto_casting
14561457
FROM employees
14571458
| WHERE birth_date IN ("1953-04-20", "1958-10-31")
14581459
| KEEP emp_no, first_name;
@@ -1463,7 +1464,7 @@ emp_no:integer | first_name:keyword
14631464
10025 | Prasadram
14641465
;
14651466

1466-
IN operator with null in list, finds match
1467+
IN operator with null in list, finds match#[skip:-8.13.99, reason: default date formatter is changed in 8.14]
14671468

14681469
FROM employees
14691470
| EVAL x = NULL
@@ -1474,7 +1475,7 @@ birth_date:datetime | first_name:keyword
14741475
1958-02-19T00:00:00.000Z | Saniya
14751476
;
14761477

1477-
IN operator with null in list, doesn't find match
1478+
IN operator with null in list, doesn't find match#[skip:-8.13.99, reason: default date formatter is changed in 8.14]
14781479

14791480
FROM employees
14801481
| EVAL x = NULL
@@ -1484,7 +1485,7 @@ FROM employees
14841485
birth_date:datetime | first_name:keyword
14851486
;
14861487

1487-
IN operator with null in list, doesn't find match, EVAL to check value
1488+
IN operator with null in list, doesn't find match, EVAL to check value#[skip:-8.13.99, reason: default date formatter is changed in 8.14]
14881489

14891490
FROM employees
14901491
| EVAL x = NULL

x-pack/plugin/esql/qa/testFixtures/src/main/resources/date_nanos.csv-spec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -741,6 +741,7 @@ ct:long | mo:date_nanos
741741
Bucket Date nanos by 10 minutes
742742
required_capability: date_trunc_date_nanos
743743
required_capability: date_nanos_bucket
744+
required_capability: string_literal_auto_casting
744745

745746
FROM date_nanos
746747
| WHERE millis > "2020-01-01"

0 commit comments

Comments
 (0)