Skip to content

Commit fac783e

Browse files
authored
Unmute SemanticInferenceMetadataFieldsRecoveryTests#testSnapshotRecovery (elastic#123590) (elastic#123992)
Modify the test to avoid using cosine similarity, as random vectors may fail the magnitude check. Closes elastic#122549 Closes elastic#122550 Closes elastic#122551
1 parent 9f67130 commit fac783e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/mapper/SemanticInferenceMetadataFieldsRecoveryTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,7 @@ protected List<MapperPlugin> extraMappers() {
7373

7474
@Override
7575
protected Settings indexSettings() {
76-
var builder = Settings.builder()
77-
.put(super.indexSettings())
78-
.put(InferenceMetadataFieldsMapper.USE_LEGACY_SEMANTIC_TEXT_FORMAT.getKey(), false);
76+
var builder = Settings.builder().put(super.indexSettings());
7977
if (useSynthetic) {
8078
builder.put(IndexSettings.INDEX_MAPPER_SOURCE_MODE_SETTING.getKey(), SourceFieldMapper.Mode.SYNTHETIC.name());
8179
builder.put(IndexSettings.RECOVERY_USE_SYNTHETIC_SOURCE_SETTING.getKey(), true);
@@ -222,7 +220,9 @@ private Translog.Snapshot newRandomSnapshot(
222220

223221
private static Model randomModel(TaskType taskType) {
224222
var dimensions = taskType == TaskType.TEXT_EMBEDDING ? randomIntBetween(2, 64) : null;
225-
var similarity = taskType == TaskType.TEXT_EMBEDDING ? randomFrom(SimilarityMeasure.values()) : null;
223+
var similarity = taskType == TaskType.TEXT_EMBEDDING
224+
? randomValueOtherThan(SimilarityMeasure.COSINE, () -> randomFrom(SimilarityMeasure.values()))
225+
: null;
226226
var elementType = taskType == TaskType.TEXT_EMBEDDING ? DenseVectorFieldMapper.ElementType.BYTE : null;
227227
return new TestModel(
228228
randomAlphaOfLength(4),

0 commit comments

Comments
 (0)