fix: resolve comment for Shiwei

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Author: JeyJeyGao

revocation/crl/fetcher.go

@@ -142,7 +142,7 @@ func (f *HTTPFetcher) fetch(ctx context.Context, url string) (*Bundle, error) {
 //
 // It returns errDeltaCRLNotFound if the delta CRL is not found.
 func (f *HTTPFetcher) fetchDeltaCRL(ctx context.Context, extensions []pkix.Extension) (*x509.RevocationList, error) {
-	extension := x509util.FindExtensionByOID(oidFreshestCRL, extensions)
+	extension := x509util.FindExtensionByOID(extensions, oidFreshestCRL)
 	if extension == nil {
 		return nil, errDeltaCRLNotFound
 	}

revocation/internal/crl/crl.go

@@ -30,21 +30,21 @@ import (
 	"golang.org/x/crypto/cryptobyte"
 )
 
-// RFC 5280, 5.3.1
-//
-//	CRLReason ::= ENUMERATED {
-//	  unspecified             (0),
-//	  keyCompromise           (1),
-//	  cACompromise            (2),
-//	  affiliationChanged      (3),
-//	  superseded              (4),
-//	  cessationOfOperation    (5),
-//	  certificateHold         (6),
-//	       -- value 7 is not used
-//	  removeFromCRL           (8),
-//	  privilegeWithdrawn      (9),
-//	  aACompromise           (10) }
 const (
+	// RFC 5280, 5.3.1
+	//
+	//	CRLReason ::= ENUMERATED {
+	//	  unspecified             (0),
+	//	  keyCompromise           (1),
+	//	  cACompromise            (2),
+	//	  affiliationChanged      (3),
+	//	  superseded              (4),
+	//	  cessationOfOperation    (5),
+	//	  certificateHold         (6),
+	//	       -- value 7 is not used
+	//	  removeFromCRL           (8),
+	//	  privilegeWithdrawn      (9),
+	//	  aACompromise           (10) }
 	// certificateHold
 	reasonCodeCertificateHold = 6
 
@@ -118,7 +118,7 @@ func CertCheckStatus(ctx context.Context, cert, issuer *x509.Certificate, opts C
 		serverResults               = make([]*result.ServerResult, 0, len(cert.CRLDistributionPoints))
 		lastErr                     error
 		crlURL                      string
-		hasFreshestCRLInCertificate = x509util.FindExtensionByOID(oidFreshestCRL, cert.Extensions) != nil
+		hasFreshestCRLInCertificate = x509util.FindExtensionByOID(cert.Extensions, oidFreshestCRL) != nil
 	)
 
 	// The CRLDistributionPoints contains the URIs of all the CRL distribution
@@ -221,7 +221,7 @@ func validate(bundle *crl.Bundle, issuer *x509.Certificate) error {
 	}
 
 	// check delta CRL indicator extension
-	extension := x509util.FindExtensionByOID(oidDeltaCRLIndicator, deltaCRL.Extensions)
+	extension := x509util.FindExtensionByOID(deltaCRL.Extensions, oidDeltaCRLIndicator)
 	if extension == nil {
 		return errors.New("delta CRL indicator extension is not found")
 	}

revocation/internal/x509util/extension.go

@@ -20,7 +20,7 @@ import (
 )
 
 // FindExtensionByOID finds the extension by the given OID.
-func FindExtensionByOID(oid asn1.ObjectIdentifier, extensions []pkix.Extension) *pkix.Extension {
+func FindExtensionByOID(extensions []pkix.Extension, oid asn1.ObjectIdentifier) *pkix.Extension {
 	idx := slices.IndexFunc(extensions, func(ext pkix.Extension) bool {
 		return ext.Id.Equal(oid)
 	})

revocation/internal/x509util/extension_test.go

@@ -49,7 +49,7 @@ func TestFindExtensionByOID(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			result := FindExtensionByOID(tt.oid, tt.extensions)
+			result := FindExtensionByOID(tt.extensions, tt.oid)
 			if result != tt.expected {
 				t.Errorf("expected %v, got %v", tt.expected, result)
 			}