Skip to content

Commit 98b777a

Browse files
committed
docs: resolve comments
Signed-off-by: Juncheng Zhu <junczhu@microsoft.com>
1 parent 93f5ce8 commit 98b777a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

cosign/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ flowchart TD
8989
- Public Key: The publicly disclosable component of a pair of cryptographic keys used for asymmetric cryptography.
9090
- Public-key Certificate: A public-key certificate binds a subject name to a public key value, along with information needed to perform certain cryptographic functions using that key.
9191
- Public-key Infrastructure (PKI): A system of CAs (and, optionally, RAs and other supporting servers and agents) that perform some set of certificate management, archive management, key management, and token management functions for a community of users in an application of asymmetric cryptography. The core PKI functions are (a) to register users and issue their public-key certificates, (b) to revoke certificates when required, and (c) to archive data needed to validate certificates at a much later time.
92-
> [!NOTE]
93-
> Cosign's keyless scenario does not follow the PKI model.
92+
> **NOTE**: Cosign's keyless scenario does not follow the PKI model.
9493
- Root CA: The root CA in a certification hierarchy issues public-key certificates to one or more additional CAs that form the second-highest level. Each of these CAs may issue certificates to more CAs at the third-highest level, and so on. To initialize operation of a hierarchical PKI, the root's initial public key is securely distributed to all certificate users in a way that does not depend on the PKI's certification relationships.
9594
- Root of Trust: Sigstore’s root of trust, which includes Fulcio’s root CA certificate and Rekor’s public key, are distributed by The Update Framework (TUF). TUF is a framework to provide secure software and file updates.
9695
- Trust Anchor: A trust anchor may be defined as being based on a public key, a CA, a public-key certificate, or some combination or variation of those. The trusted anchor information is trusted because it was delivered to the path processing procedure by some trustworthy out-of-band procedure.
@@ -115,7 +114,7 @@ flowchart TD
115114
To verify a keyless signed Cosign signature, you need to verify the following trust chain:
116115

117116
- Check if the artifact matches what is described in the signature
118-
- Check if the OIDC identify (subject & issuer) matches what is described in the signature
117+
- Check if the OIDC identity (subject & issuer) matches what is described in the signature
119118
- Check if the certificate and the timestamp in signature are valid against Fulcio and Rekor
120119
- The root trust of Fulcio and Rekor is sourced from https://tuf-repo-cdn.sigstore.dev/
121120
- The root trust of https://tuf-repo-cdn.sigstore.dev/ is from the Cosign binary
@@ -131,7 +130,8 @@ To verify a keyless signed Cosign signature, you need to verify the following tr
131130

132131
2. Verification Materials
133132
- Identity Parameters: Restrict verification to specific OIDC identities. Valid values include email address, DNS names, IP addresses, and URIs.
134-
- OIDC Issuer Parameters: Ensure the certificate was issued by a specific OIDC provider, without Fulcio roots (for BYO PKI).
133+
- OIDC Issuer Parameters: Ensure the certificate was issued by a specific OIDC provider.
134+
> **NOTE**: Non-Fulcio roots are supported in bring your own (BYO) PKI scenario.
135135
136136
#### Keyless Verify Output
137137

@@ -177,7 +177,7 @@ The checks were performed:
177177
### Cosign Library Key-based Verify
178178

179179
Cosign signs the artifact with the private key and upload the signature transparency log to the Rekor server `rekor.sigstore.dev`
180-
To verify a keyless signed Cosign signature, you need to verify the following trust chain:
180+
To verify a key-based signed Cosign signature, you need to verify the following trust chain:
181181

182182
- Check if the artifact matches what is described in the signature
183183
- Check if the signature was created using the expected public key

0 commit comments

Comments
 (0)