fixes #153, remove the inspector feature

Author: yjpark

apps/notation_kb/Makefile.toml

@@ -50,10 +50,6 @@ dependencies = ["build-web", "basic-http-server"]
 [tasks.test]
 disabled = true
 
-[tasks.release-inspector]
-args = ["bundle", "--features", "inspector", "@@split(CARGO_RELEASE_ARGS, )"]
-command = "cargo"
-
 [tasks.release-native]
 args = ["bundle", "--features", "native", "@@split(CARGO_RELEASE_ARGS, )"]
 command = "cargo"

apps/notation_kb_cn/Makefile.toml

@@ -50,10 +50,6 @@ dependencies = ["build-web", "basic-http-server"]
 [tasks.test]
 disabled = true
 
-[tasks.release-inspector]
-args = ["bundle", "--features", "inspector", "@@split(CARGO_RELEASE_ARGS, )"]
-command = "cargo"
-
 [tasks.release-native]
 args = ["bundle", "--features", "native", "@@split(CARGO_RELEASE_ARGS, )"]
 command = "cargo"

apps/notation_viewer/Makefile.toml

@@ -50,10 +50,6 @@ dependencies = ["build-web", "basic-http-server"]
 [tasks.test]
 disabled = true
 
-[tasks.release-inspector]
-args = ["bundle", "--features", "inspector", "@@split(CARGO_RELEASE_ARGS, )"]
-command = "cargo"
-
 [tasks.release-native]
 args = ["bundle", "--features", "native", "@@split(CARGO_RELEASE_ARGS, )"]
 command = "cargo"

apps/notation_viewer_cn/Makefile.toml

@@ -50,10 +50,6 @@ dependencies = ["build-web", "basic-http-server"]
 [tasks.test]
 disabled = true
 
-[tasks.release-inspector]
-args = ["bundle", "--features", "inspector", "@@split(CARGO_RELEASE_ARGS, )"]
-command = "cargo"
-
 [tasks.release-native]
 args = ["bundle", "--features", "native", "@@split(CARGO_RELEASE_ARGS, )"]
 command = "cargo"

crates/notation_bevy/Cargo.toml

@@ -66,13 +66,6 @@ bevy_asset_loader = "0.8.0"
 rfd = "0.6.3"
 lazy_static = "1.4.0"
 
-#[target."cfg(not(target_arch = "wasm32"))".dependencies]
-# Can not enable bevy_wgpu in this way, so the actually binary crate
-# need to include native feature manually
-# https://github.com/rust-lang/cargo/issues/1197
-# if not providing the dev and inspector feature, then can create a
-# wrapper crate, though think having these features benefits more
-
 [target.'cfg(target_arch = "wasm32")'.dependencies]
 wasm-bindgen = "0.2.78"
 console_error_panic_hook = "0.1"

crates/notation_bevy/src/inspector/mod.rs

@@ -11,9 +11,6 @@ pub use notation_midi;
 
 pub use {bevy, bevy_prototype_lyon, bevy_egui, bevy_asset_loader};
 
-#[cfg(feature = "inspector")]
-pub use bevy_inspector_egui;
-
 pub mod chord;
 pub mod entry;
 pub mod tone;
@@ -43,9 +40,6 @@ pub mod notation;
 #[cfg(target_arch = "wasm32")]
 pub mod wasm;
 
-#[cfg(feature = "inspector")]
-pub mod inspector;
-
 #[cfg(feature = "dev")]
 pub mod dev;
 

crates/notation_bevy/src/inspector/syllable.rs

@@ -86,9 +86,6 @@ impl NotationApp {
         #[cfg(feature = "dev")]
         app.add_plugins(crate::dev::NotationDevPlugins);
 
-        #[cfg(feature = "inspector")]
-        app.add_plugins(crate::inspector::NotationInspectorPlugins);
-
         app
     }
 

crates/notation_bevy/src/lib.rs

@@ -7,16 +7,12 @@ use notation_model::lane_kind::LaneKind;
 use notation_model::prelude::Position;
 use serde::{Deserialize, Serialize};
 
-#[cfg(feature = "inspector")]
-use bevy_inspector_egui::Inspectable;
-
 use crate::bar::bar_layout::BarLayoutData;
 use crate::lane::lane_layout::LaneLayoutData;
 use crate::play::pos_indicator::PosIndicatorData;
 use crate::prelude::{NotationTheme, TabBars};
 
 #[derive(Copy, Clone, PartialEq, Eq, Serialize, Deserialize, Debug)]
-#[cfg_attr(feature = "inspector", derive(Inspectable))]
 pub enum LayoutMode {
     Grid,
     Line,
@@ -28,7 +24,6 @@ impl Default for LayoutMode {
 }
 
 #[derive(Copy, Clone, PartialEq, Eq, Serialize, Deserialize, Debug)]
-#[cfg_attr(feature = "inspector", derive(Inspectable))]
 pub enum GridAlignMode {
     Center,
     ForceCenter,
@@ -42,7 +37,6 @@ impl Default for GridAlignMode {
 }
 
 #[derive(Clone, Serialize, Deserialize, Debug)]
-#[cfg_attr(feature = "inspector", derive(Inspectable))]
 pub struct LayoutSettings {
     pub mode: LayoutMode,
     pub grid_align_mode: GridAlignMode,