Skip to content

Commit 27a34b7

Browse files
shouplesrgbkrk
andauthored
[deno] update to latest commit (#43)
* update to latest commit * update tag again * add `jupyter --install` & `--kernel` * consistent formatting * swap install to image build * Update deno/base/1.37-dev/Dockerfile * Update deno/base/1.37-dev/Dockerfile * empty commit * comment --------- Co-authored-by: Kyle Kelley <[email protected]>
1 parent ae84af4 commit 27a34b7

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

deno/Aptfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ tini
22
curl
33
cmake
44
protobuf-compiler
5+
jupyter

deno/base/1.37-dev/Dockerfile

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,18 @@ USER noteable
3636

3737
ENV PATH="/srv/noteable/.cargo/bin:${PATH}"
3838

39-
# install deno from latest commit in `jupyter2` branch
39+
# install deno from latest commit when jupyter2 branch was merged
4040
# TODO: update this once merged to main branch and use package install instead
4141
RUN cargo install \
42-
--git https://github.com/bartlomieju/deno \
43-
--rev 01ac23d431eed61308c27edad30d44040ae142cb \
42+
--git https://github.com/denoland/deno \
43+
--rev bf0760411336ce5ebb1c103f766c8154af478414 \
4444
--features __runtime_js_sources \
4545
deno
4646

47+
# the kernel needs the deno kernelspec discoverable locally before it can start
48+
# hadolint ignore=DL3059
49+
RUN deno --unstable jupyter --install
50+
4751
COPY secrets_helper.sh /tmp/secrets_helper.sh
4852
COPY run.sh /usr/local/bin
4953

deno/run.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ source /tmp/secrets_helper.sh
1414
echo "Done injecting Secrets, turning echoing back on"
1515
set -x
1616

17-
1817
echo "Starting Deno kernel"
19-
20-
exec deno --unstable jupyter --conn /etc/noteable/connections/connection_file.json
18+
exec deno --unstable \
19+
jupyter \
20+
--conn /etc/noteable/connections/connection_file.json \
21+
--kernel

0 commit comments

Comments
 (0)