Skip to content

Commit a635ac6

Browse files
committed
Make error log more clear
1 parent 9ebf178 commit a635ac6

File tree

1 file changed

+24
-4
lines changed

1 file changed

+24
-4
lines changed

src/verifySignedfile.cpp

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -293,25 +293,45 @@ bool SecurityGuard::verifySignedBinary(const std::wstring& filepath)
293293
if (status && (!_signer_display_name.empty() && _signer_display_name != display_name))
294294
{
295295
status = false;
296-
writeSecurityError(filepath.c_str(), display_name + L": Invalid certificate display name");
296+
wstring errMsg = L"Invalid certificate display name: ";
297+
errMsg += L"expected ";
298+
errMsg += _signer_display_name;
299+
errMsg += L" vs unexpected ";
300+
errMsg += display_name;
301+
writeSecurityError(filepath.c_str(), errMsg);
297302
}
298303

299304
if (status && (!_signer_subject.empty() && _signer_subject != subject))
300305
{
301306
status = false;
302-
writeSecurityError(filepath.c_str(), subject + L": Invalid certificate subject");
307+
wstring errMsg = L"Invalid certificate subject: ";
308+
errMsg += L"expected ";
309+
errMsg += _signer_subject;
310+
errMsg += L" vs unexpected ";
311+
errMsg += subject;
312+
writeSecurityError(filepath.c_str(), errMsg);
303313
}
304314

305315
if (status && (!_signer_key_id.empty() && stringToUpper(_signer_key_id) != key_id_hex))
306316
{
307317
status = false;
308-
writeSecurityError(filepath.c_str(), key_id_hex + L": Invalid certificate key id");
318+
wstring errMsg = L"Invalid certificate key id: ";
319+
errMsg += L"expected ";
320+
errMsg += _signer_key_id;
321+
errMsg += L" vs unexpected ";
322+
errMsg += key_id_hex;
323+
writeSecurityError(filepath.c_str(), errMsg);
309324
}
310325

311326
if (status && (!_authority_key_id.empty() && stringToUpper(_authority_key_id) != authority_key_id_hex))
312327
{
313328
status = false;
314-
writeSecurityError(filepath.c_str(), authority_key_id_hex + L": Invalid authority key id");
329+
wstring errMsg = L"Invalid authority key id: ";
330+
errMsg += L"expected ";
331+
errMsg += _authority_key_id;
332+
errMsg += L" vs unexpected ";
333+
errMsg += authority_key_id_hex;
334+
writeSecurityError(filepath.c_str(), errMsg);
315335
}
316336

317337
// Clean up.

0 commit comments

Comments
 (0)