Log decoding errors.

Author: SebastianStehle

sdk/Notifo.SDK.FirebasePlugin/NotifoPushNotificationHandler.android.cs

@@ -40,6 +40,7 @@ public override void OnReceived(IDictionary<string, object> parameters)
             if (parameters.TryGetValue(IdKey, out var id))
             {
                 var notificationId = Math.Abs(id.GetHashCode());
+
                 parameters[IdKey] = notificationId;
             }
 

sdk/Notifo.SDK/Extensions/StringExtensions.cs

@@ -43,6 +43,11 @@ public static string AppendQueries(this string url, string? key1, object? value1
         }
 
         public static string AppendQueries(this string url, string? key1, object? value1, string? key2, object? value2)
+        {
+            return AppendQueries(url, key1, value1, key2, value2, null!, null!);
+        }
+
+        public static string AppendQueries(this string url, string? key1, object? value1, string? key2, object? value2, string? key3, object? value3)
         {
             if (string.IsNullOrWhiteSpace(url))
             {
@@ -80,6 +85,7 @@ void Append(string? key, object? value)
 
             Append(key1, value1);
             Append(key2, value2);
+            Append(key3, value3);
 
             return builder.ToString();
         }

sdk/Notifo.SDK/NotifoMobilePush/NotifoMobilePushImplementation.android.cs

@@ -92,27 +92,34 @@ internal void OnBuildNotification(NotificationCompat.Builder notificationBuilder
             notificationHandler?.OnBuildNotification(notificationBuilder, notification);
         }
 
-        private Bitmap? GetBitmap(string bitmapUrl, int width = -1, int height = -1)
+        private Bitmap? GetBitmap(string bitmapUrl, int? width = null, int? height = null)
         {
             try
             {
                 // Let the server resize the image to the perfect format.
-                bitmapUrl = bitmapUrl.AppendQueries("width", width, "height", height);
+                if (width != null && height != null)
+                {
+                    bitmapUrl = bitmapUrl.AppendQueries("width", width, "height", height);
+                }
 
                 if (bitmapCache.TryGetValue(bitmapUrl, out Bitmap cachedBitmap))
                 {
                     return cachedBitmap;
                 }
 
                 var bitmapStream = new URL(bitmapUrl)?.OpenConnection()?.InputStream;
+                var bitmapImage = BitmapFactory.DecodeStream(bitmapStream);
 
-                var bitmap = BitmapFactory.DecodeStream(bitmapStream);
-                if (bitmap != null)
+                if (bitmapImage != null)
+                {
+                    bitmapCache.Set(bitmapUrl, bitmapImage);
+                }
+                else
                 {
-                    bitmapCache.Set(bitmapUrl, bitmap);
+                    NotifoIO.Current.RaiseError(Strings.DecodingImageError, null, this);
                 }
 
-                return bitmap;
+                return bitmapImage;
             }
             catch (Exception ex)
             {

sdk/Notifo.SDK/Resources/Strings.Designer.cs

@@ -120,6 +120,9 @@
   <data name="CommandError" xml:space="preserve">
     <value>Command queue has thrown an error.</value>
   </data>
+  <data name="DecodingImageError" xml:space="preserve">
+    <value>Could not decode image.</value>
+  </data>
   <data name="DownloadImageError" xml:space="preserve">
     <value>Could not download image.</value>
   </data>