Added todos

Author: SebastianStehle

sdk/Notifo.SDK/Constants.cs

@@ -10,24 +10,43 @@ namespace Notifo.SDK
     internal static class Constants
     {
         public const string ApsAlertBodyKey = "aps.alert.body";
+
         public const string ApsAlertTitleKey = "aps.alert.title";
+
         public const string ApsKey = "aps";
+
         public const string BodyKey = "body";
+
         public const string ConfirmAction = "notifo-confirm-action";
+
         public const string ConfirmTextKey = "confirmText";
+
         public const string ConfirmUrlKey = "confirmUrl";
+
         public const string ContentAvailableKey = "content-available";
+
         public const string DataKey = "data";
+
         public const string IdKey = "id";
+
         public const string ImageLargeKey = "imageLarge";
+
         public const string ImageSmallKey = "imageSmall";
+
         public const string IsConfirmedKey = "isConfirmed";
+
         public const string IsSeenKey = "isSeen";
+
         public const string LinkAction = "notifo-link-action";
+
         public const string LinkTextKey = "linkText";
+
         public const string LinkUrlKey = "linkUrl";
+
         public const string SilentKey = "silent";
+
         public const string SubjectKey = "subject";
+
         public const string TrackingUrlKey = "trackingUrl";
     }
 }

sdk/Notifo.SDK/NotifoMobilePush/NotifoMobilePushImplementation.ios.cs

@@ -154,18 +154,19 @@ private async Task<UNMutableNotificationContent> EnrichNotificationContentAsync(
                 content.Body = notification.Body;
             }
 
-            string image = string.IsNullOrWhiteSpace(notification.ImageLarge) ? notification.ImageSmall : notification.ImageLarge;
+            var image = string.IsNullOrWhiteSpace(notification.ImageLarge) ? notification.ImageSmall : notification.ImageLarge;
 
             if (!string.IsNullOrWhiteSpace(image))
             {
                 var imagePath = await GetImageAsync(image);
 
                 if (!string.IsNullOrWhiteSpace(imagePath))
                 {
-                    var uniqueName = $"{Guid.NewGuid()}{Path.GetExtension(imagePath)}";
-                    var attachementUrl = new NSUrl(uniqueName, NSFileManager.DefaultManager.GetTemporaryDirectory());
+                    var attachmentName = $"{Guid.NewGuid()}{Path.GetExtension(imagePath)}";
+                    var attachmentUrl = new NSUrl(attachmentName, NSFileManager.DefaultManager.GetTemporaryDirectory());
 
-                    NSFileManager.DefaultManager.Copy(NSUrl.FromFilename(imagePath), attachementUrl, out var error);
+                    // TODO: We copy the image twice. Really weird.
+                    NSFileManager.DefaultManager.Copy(NSUrl.FromFilename(imagePath), attachmentUrl, out var error);
 
                     if (error != null)
                     {
@@ -174,7 +175,7 @@ private async Task<UNMutableNotificationContent> EnrichNotificationContentAsync(
 
                     var attachement = UNNotificationAttachment.FromIdentifier(
                         Constants.ImageLargeKey,
-                        attachementUrl,
+                        attachmentUrl,
                         new UNNotificationAttachmentOptions(),
                         out error);
 
@@ -290,7 +291,7 @@ private async Task<string> GetImageAsync(string imageUrl)
         {
             try
             {
-                // Not really sure if the dictionary provides any value at all.
+                // TODO: Not really sure if the dictionary provides any value at all.
                 if (imageCache.TryGetValue(imageUrl, out string imagePath) && File.Exists(imagePath))
                 {
                     return imagePath;