Update 'seen notification' storing mechanism.

Author: sanyandreichuk

sdk/Notifo.SDK/NotifoMobilePush/NotifoMobilePushImplementation.shared.cs

@@ -261,9 +261,10 @@ private async Task<ICollection<NotificationDto>> GetPendingNotificationsAsync()
             try
             {
                 var allNotifications = await Notifications.GetNotificationsAsync();
+                var seenNotifications = settings.GetSeenNotifications();
                 var pendingNotifications = allNotifications
                     .Items
-                    .Where(x => !settings.IsNotificationSeen(x.Id))
+                    .Where(x => !seenNotifications.Contains(x.Id))
                     .OrderBy(x => x.Created)
                     .ToArray();
 

sdk/Notifo.SDK/Services/ISettings.cs

@@ -8,6 +8,7 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using Notifo.SDK.Helpers;
 
 namespace Notifo.SDK.Services
 {
@@ -21,6 +22,6 @@ internal interface ISettings
 
         Task TrackNotificationsAsync(IEnumerable<Guid> ids);
 
-        bool IsNotificationSeen(Guid id);
+        SlidingSet<Guid> GetSeenNotifications();
     }
 }

sdk/Notifo.SDK/Services/Settings.cs

@@ -20,6 +20,7 @@ internal class Settings : ISettings
     {
         private static readonly string PrimaryPackageName = Regex.Replace(AppInfo.PackageName, @"\.([^.]*)ServiceExtension$", string.Empty);
         private static readonly string SharedName = $"group.{PrimaryPackageName}.notifo";
+        private static readonly string SeenNotificationsKey = "SeenNotifications";
 
         private static readonly SemaphoreSlim Semaphore = new SemaphoreSlim(1, 1);
 
@@ -35,60 +36,40 @@ public bool IsTokenRefreshed
             set => Preferences.Set(nameof(IsTokenRefreshed), value, SharedName);
         }
 
-        private SlidingSet<Guid> seenNotifications;
-        private SlidingSet<Guid> SeenNotifications
+        public SlidingSet<Guid> GetSeenNotifications()
         {
-            get
-            {
-                if (seenNotifications == null)
-                {
-                    seenNotifications = new SlidingSet<Guid>(capacity: 500);
+            var seenNotifications = new SlidingSet<Guid>(capacity: 500);
 
-                    var serialized = Preferences.Get(nameof(SeenNotifications), string.Empty, SharedName);
-                    if (!string.IsNullOrWhiteSpace(serialized))
-                    {
-                        seenNotifications = JsonConvert.DeserializeObject<SlidingSet<Guid>>(serialized) ?? seenNotifications;
-                    }
-                }
-
-                return seenNotifications;
-            }
-            set
+            var serialized = Preferences.Get(SeenNotificationsKey, string.Empty, SharedName);
+            if (!string.IsNullOrWhiteSpace(serialized))
             {
-                seenNotifications = value;
-
-                var serialized = JsonConvert.SerializeObject(seenNotifications);
-                Preferences.Set(nameof(SeenNotifications), serialized, SharedName);
+                seenNotifications = JsonConvert.DeserializeObject<SlidingSet<Guid>>(serialized) ?? seenNotifications;
             }
-        }
 
-        public bool IsNotificationSeen(Guid id) => SeenNotifications.Contains(id);
+            return seenNotifications;
+        }
 
-        public async Task TrackNotificationAsync(Guid id)
+        private void SetSeenNotifications(SlidingSet<Guid> seenNotifications)
         {
-            await Semaphore.WaitAsync();
-            try
-            {
-                SeenNotifications.Add(id);
-                await Task.Run(() => SeenNotifications = SeenNotifications);
-            }
-            finally
-            {
-                Semaphore.Release();
-            }
+            var serialized = JsonConvert.SerializeObject(seenNotifications);
+            Preferences.Set(SeenNotificationsKey, serialized, SharedName);
         }
 
+        public Task TrackNotificationAsync(Guid id) => TrackNotificationsAsync(new Guid[] { id });
+
         public async Task TrackNotificationsAsync(IEnumerable<Guid> ids)
         {
             await Semaphore.WaitAsync();
             try
             {
+                var seenNotifications = GetSeenNotifications();
+
                 foreach (var id in ids)
                 {
-                    SeenNotifications.Add(id);
+                    seenNotifications.Add(id);
                 }
 
-                await Task.Run(() => SeenNotifications = SeenNotifications);
+                await Task.Run(() => SetSeenNotifications(seenNotifications));
             }
             finally
             {