Filter watch targets (+ Windows and kqueue support) #717
+250
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-watch-targets # Conflicts: # notify/src/fsevent.rs # notify/src/inotify.rs # notify/src/lib.rs
boenrobot
force-pushed
the
filter-watch-targets
branch
from
43633b5 to
b91b6c8
Compare
boenrobot
changed the title
boenrobot
commented
Oct 19, 2025
|
|
||
| for path in add_watches { | ||
| self.add_watch(path, true).ok(); | ||
| self.add_watch(path, true, WatchFilter::accept_all()).ok(); |
There was a problem hiding this comment.
I can't put my finger on the exact scenario, but this feels wrong... I feel like I should be inferring the filter out of a previously saved copy in self.watches... But then if that is what should be happening, I'm not sure how to efficiently determine the correct watch entry to fetch it from, and combined with the lack of being able to test locally, I'm reluctant to try playing around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up where #632 left off.
I resolved the conflicts, and in a separate commit, also added support for Windows... I'm not sure if that Windows supports really works properly to be honest, as there's no tests in #632, and I'm not sure how to even write a proper test for this (I'm new to Rust...).
But certainly all the tests pass and there's no warnings (except one in windows.rs that was there from before this PR and not introduced by #632 either), so... that's a good start.
EDIT: OK, I see CI shows kqueue breaking due to lack of implementation in both #632 and this one... I'll see if I can implement it, though I should note I am only using Windows, and have WSL... No FreeBSD or MacOS available, so I'll rely on the CI...Also implemented kqueue, though once again, without any tests... Just the build and existing tests passing.