Externalize script settings and workflow improvements

Author: jamezrin

.github/release-drafter.yml

@@ -0,0 +1,4 @@
+template: |
+  ## Changes
+
+  $CHANGES

.github/workflows/main.yml renamed to .github/workflows/notion-repackaged.yml

@@ -1,25 +1,36 @@
-name: Notion Repackage
+name: Notion Repackaged Main
 
 on:
   push:
     branches: [main]
+    paths:
+      - 'notion-repackaged.env'
 
   workflow_dispatch:
     inputs: {}
 
 env:
-  NOTION_VERSION: 2.0.16
-  NOTION_DOWNLOAD_HASH: 9f72284086cda3977f7f569dff3974d5
-  NOTION_ENHANCER_COMMIT: b248ffa3bac393f267a4600d4e951aba8565f31e
-  NOTION_REPACKAGED_REVISION: 1
   NOTION_REPACKAGED_DEBUG: true
 
 jobs:
+  create-release:
+    name: Create release
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - run: grep -v '^#' notion-repackaged.env >> $GITHUB_ENV
+      - uses: release-drafter/release-drafter@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          version: "${{ env.NOTION_VERSION }}-${{ env.NOTION_REPACKAGED_REVISION }}"
+
   make-vanilla-sources:
     name: Make vanilla sources
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - run: grep -v '^#' notion-repackaged.env >> $GITHUB_ENV
       - name: Download official Windows build
         run: scripts/download-exe.sh
       - name: Extract sources from Windows Build
@@ -39,6 +50,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+      - run: grep -v '^#' notion-repackaged.env >> $GITHUB_ENV
       - name: Retrieve saved vanilla sources
         uses: actions/download-artifact@v2
         with:
@@ -62,7 +74,7 @@ jobs:
 
   build-app:
     name: Build app
-    needs: [make-vanilla-sources, make-enhanced-sources]
+    needs: [make-vanilla-sources, make-enhanced-sources, create-release]
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -82,6 +94,7 @@ jobs:
             edition: vanilla
     steps:
       - uses: actions/checkout@v2
+      - run: grep -v '^#' notion-repackaged.env >> $GITHUB_ENV
       - uses: actions/setup-node@v1
         with:
           node-version: 14

.github/workflows/potential-duplicates.yml

@@ -0,0 +1,23 @@
+name: Potential Duplicates
+
+on:
+  issues:
+    types: [opened, edited]
+
+jobs:
+  run:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: bubkoo/potential-duplicates@v1
+        with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          filter: ''
+          exclude: ''
+          label: potential-duplicate
+          state: all
+          threshold: 0.6
+          reactions: 'eyes, confused'
+          comment: >
+            Potential duplicates: {{#issues}}
+              - [#{{ number }}] {{ title }} ({{ accuracy }}%)
+            {{/issues}}

.github/workflows/stale-issues.yml

@@ -0,0 +1,20 @@
+name: Close inactive issues
+
+on:
+  schedule:
+    - cron: "30 1 * * *"
+
+jobs:
+  close-issues:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v3
+        with:
+          days-before-issue-stale: 45
+          days-before-issue-close: 14
+          stale-issue-label: "stale"
+          stale-issue-message: "This issue is stale because it has been open for 30 days with no activity."
+          close-issue-message: "This issue was closed because it has been inactive for 14 days since being marked as stale."
+          days-before-pr-stale: -1
+          days-before-pr-close: -1
+          repo-token: ${{ secrets.GITHUB_TOKEN }}

notion-repackaged.env

@@ -0,0 +1,4 @@
+NOTION_VERSION=2.0.16
+NOTION_REPACKAGED_REVISION=2
+NOTION_DOWNLOAD_HASH=9f72284086cda3977f7f569dff3974d5
+NOTION_ENHANCER_COMMIT=b248ffa3bac393f267a4600d4e951aba8565f31e

scripts/_utils.sh

@@ -1,28 +1,4 @@
-set -a
-
-WORKSPACE_DIR=`realpath $(dirname $0)/..`
-
-NOTION_VERSION="${NOTION_VERSION:-2.0.16}"
-NOTION_DOWNLOAD_HASH="${NOTION_DOWNLOAD_HASH:-9f72284086cda3977f7f569dff3974d5}"
-NOTION_DOWNLOAD_URL="https://desktop-release.notion-static.com/Notion%20Setup%20${NOTION_VERSION}.exe"
-NOTION_DOWNLOADED_NAME="Notion-${NOTION_VERSION}.exe"
-
-NOTION_ENHANCER_COMMIT="${NOTION_ENHANCER_COMMIT:-b248ffa3bac393f267a4600d4e951aba8565f31e}"
-NOTION_ENHANCER_REPO_URL="https://github.com/notion-enhancer/notion-enhancer"
-
-NOTION_EXTRACTED_EXE_NAME="extracted-exe"
-NOTION_EXTRACTED_APP_NAME="extracted-app"
-NOTION_VANILLA_SRC_NAME="vanilla-src"
-NOTION_ENHANCED_SRC_NAME="enhanced-src"
-NOTION_EMBEDDED_NAME="embedded_enhancer"
-
-NOTION_REPACKAGED_REVISION="${NOTION_REPACKAGED_REVISION:-1}"
-NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-${NOTION_REPACKAGED_REVISION}"
-NOTION_REPACKAGED_HOMEPAGE="https://github.com/jamezrin/notion-repackaged"
-NOTION_REPACKAGED_REPO=${NOTION_REPACKAGED_REPO:-${NOTION_REPACKAGED_HOMEPAGE}}
-NOTION_REPACKAGED_AUTHOR="Notion Repackaged"
-
-set +a
+export WORKSPACE_DIR=`realpath $(dirname $0)/..`
 
 function log() {
   caller=`basename "$0"`
@@ -36,6 +12,15 @@ function check-cmd() {
   fi
 }
 
+function check-env() {
+  for var_name in "$@"; do
+    if [ -z "${!var_name}" ]; then
+      log "Required environment variable $var_name is not set"
+      exit -1
+    fi
+  done
+}
+
 function workspace-dir-pushd() {
   mkdir -p "${WORKSPACE_DIR}/build"
   pushd "${WORKSPACE_DIR}/build" > /dev/null
@@ -46,3 +31,21 @@ function check-debug-expands() {
     set -x
   fi
 }
+
+check-env NOTION_VERSION NOTION_REPACKAGED_REVISION NOTION_DOWNLOAD_HASH NOTION_ENHANCER_COMMIT
+
+export NOTION_DOWNLOAD_URL="https://desktop-release.notion-static.com/Notion%20Setup%20${NOTION_VERSION}.exe"
+export NOTION_DOWNLOADED_NAME="Notion-${NOTION_VERSION}.exe"
+
+
+export NOTION_ENHANCER_REPO_URL="https://github.com/notion-enhancer/notion-enhancer"
+export NOTION_EXTRACTED_EXE_NAME="extracted-exe"
+export NOTION_EXTRACTED_APP_NAME="extracted-app"
+export NOTION_VANILLA_SRC_NAME="vanilla-src"
+export NOTION_ENHANCED_SRC_NAME="enhanced-src"
+export NOTION_EMBEDDED_NAME="embedded_enhancer"
+
+export NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-${NOTION_REPACKAGED_REVISION}"
+export NOTION_REPACKAGED_HOMEPAGE="https://github.com/jamezrin/notion-repackaged"
+export NOTION_REPACKAGED_REPO=${NOTION_REPACKAGED_REPO:-${NOTION_REPACKAGED_HOMEPAGE}}
+export NOTION_REPACKAGED_AUTHOR="Notion Repackaged"

scripts/build-locally.sh

@@ -8,21 +8,33 @@ workspace-dir-pushd
 check-cmd jq
 check-cmd git
 
-if [ ! -d "${NOTION_ENHANCED_SRC_NAME}" ]; then
-  log "Sources do not seem to have been made..."
-  exit 1
+if [ -z "${NOTION_REPACKAGED_EDITION}" ]; then
+  log "Cannot build without knowing the edition to build, please set NOTION_REPACKAGED_EDITION env var"
+  exit -1
 fi
 
-pushd "${NOTION_ENHANCED_SRC_NAME}" > /dev/null
+if [ "${NOTION_REPACKAGED_EDITION}" == "enhanced" ]; then
+  NOTION_REPACKAGED_EDITION_SRCDIR="${NOTION_ENHANCED_SRC_NAME}"
+elif [ "${NOTION_REPACKAGED_EDITION}" == "vanilla" ]; then
+  NOTION_REPACKAGED_EDITION_SRCDIR="${NOTION_VANILLA_SRC_NAME}"
+else
+  log "Invalid value for the NOTION_REPACKAGED_EDITION env var, it has to either be 'vanilla' or 'enhanced'"
+  exit -1
+fi
+
+if [ ! -d "${NOTION_REPACKAGED_EDITION_SRCDIR}" ]; then
+  log "Could not find the directory for this edition's sources, please build them first"
+  exit -1
+fi
+
+pushd "${NOTION_REPACKAGED_EDITION_SRCDIR}" > /dev/null
 
 log "Installing dependencies..."
 npm install
 
 log "Install electron and electron-builder..."
 npm install electron@11 electron-builder --save-dev
 
-export NOTION_REPACKAGED_EDITION=enhanced
-
 log "Running electron-builder..."
 node_modules/.bin/electron-builder \
   --config $WORKSPACE_DIR/electron-builder.js $@