Skip to content

Commit 8ae7880

Browse files
committed
Revert "Try app release channels"
This reverts commit d2958a4.
1 parent d2958a4 commit 8ae7880

File tree

3 files changed

+9
-21
lines changed

3 files changed

+9
-21
lines changed

.github/workflows/notion-repackaged.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
echo "::set-output name=notion_download_hash::$NOTION_DOWNLOAD_HASH"
3030
echo "::set-output name=notion_enhancer_desktop_commit::$NOTION_ENHANCER_DESKTOP_COMMIT"
3131
32-
NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-{0}.${NOTION_REPACKAGED_REVISION}"
32+
NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-${NOTION_REPACKAGED_REVISION}"
3333
echo "::set-output name=notion_repackaged_version_rev::$NOTION_REPACKAGED_VERSION_REV"
3434
outputs:
3535
notion_version: ${{ steps.preload-variables.outputs.notion_version }}
@@ -42,17 +42,14 @@ jobs:
4242
name: Create release
4343
runs-on: ubuntu-latest
4444
needs: [preload-variables]
45-
strategy:
46-
matrix:
47-
edition: [vanilla, enhanced]
4845
steps:
4946
- uses: actions/checkout@v2
5047
- uses: release-drafter/release-drafter@v5
5148
env:
5249
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5350
with:
54-
version: ${{ format(needs.preload-variables.outputs.notion_repackaged_version_rev, matrix.edition) }}
55-
tag: v${{ format(needs.preload-variables.outputs.notion_repackaged_version_rev, matrix.edition) }}
51+
version: ${{ needs.preload-variables.outputs.notion_repackaged_version_rev }}
52+
tag: v${{ needs.preload-variables.outputs.notion_repackaged_version_rev }}
5653

5754
make-vanilla-sources:
5855
name: Make vanilla sources
@@ -82,11 +79,8 @@ jobs:
8279

8380
make-enhanced-sources:
8481
name: Make enhanced sources
85-
runs-on: ubuntu-latest
8682
needs: [make-vanilla-sources, preload-variables]
87-
env:
88-
NOTION_VERSION: ${{ needs.preload-variables.outputs.notion_version }}
89-
NOTION_REPACKAGED_REVISION: ${{ needs.preload-variables.outputs.notion_repackaged_revision }}
83+
runs-on: ubuntu-latest
9084
steps:
9185
- uses: actions/checkout@v2
9286
- name: Install icnsutils and moreutils

scripts/enhance-src.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ source `dirname $0`/_utils.sh
55
workdir ${WORKSPACE_BUILD_DIR}
66

77
check-cmd jq git convert png2icns node sponge
8-
check-env NOTION_VERSION NOTION_REPACKAGED_REVISION NOTION_ENHANCER_DESKTOP_COMMIT
8+
check-env NOTION_ENHANCER_DESKTOP_COMMIT
99

1010
if [ -d "${NOTION_ENHANCED_SRC_NAME}" ]; then
1111
log "Removing already enhanced sources..."
@@ -23,13 +23,7 @@ pushd "${NOTION_ENHANCED_SRC_NAME}" > /dev/null
2323

2424
log "Patching package.json for being enhanced..."
2525

26-
NOTION_APP_PACKAGE_VERSION="${NOTION_VERSION}-enhanced.${NOTION_REPACKAGED_REVISION}"
27-
28-
jq \
29-
--arg version "${NOTION_APP_PACKAGE_VERSION}" \
30-
'.name="notion-app-enhanced" |
31-
.version=$version' \
32-
package.json | sponge package.json
26+
jq '.name="notion-app-enhanced"' package.json | sponge package.json
3327

3428
popd > /dev/null
3529

scripts/extract-src.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ log "Copying original app resources..."
3636
mkdir -p "${NOTION_VANILLA_SRC_NAME}"
3737
cp -r "${NOTION_EXTRACTED_APP_NAME}/resources/app/"* "${NOTION_VANILLA_SRC_NAME}"
3838

39+
export NOTION_REPACKAGED_VERSION_REV="${NOTION_VERSION}-${NOTION_REPACKAGED_REVISION}"
40+
3941
pushd "${NOTION_VANILLA_SRC_NAME}" > /dev/null
4042

4143
log "Patching and cleaning source"
@@ -58,13 +60,11 @@ find . -type f -name "*.js.map" -exec rm {} +
5860

5961
log "Adapting package.json including fixes..."
6062

61-
NOTION_APP_PACKAGE_VERSION="${NOTION_VERSION}-vanilla.${NOTION_REPACKAGED_REVISION}"
62-
6363
jq \
64-
--arg version "${NOTION_APP_PACKAGE_VERSION}" \
6564
--arg homepage "${NOTION_REPACKAGED_HOMEPAGE}" \
6665
--arg repo "${NOTION_REPACKAGED_REPO}" \
6766
--arg author "${NOTION_REPACKAGED_AUTHOR}" \
67+
--arg version "${NOTION_REPACKAGED_VERSION_REV}" \
6868
'.dependencies.cld="2.7.0" |
6969
.name="notion-app" |
7070
.homepage=$homepage |

0 commit comments

Comments
 (0)